Merge pull request #190 from thenewboston-developers/BC-271-cv-to-cv-block-confirmation

NodeClient.send_block_confirmation()

Author: dmugtasimov

node/core/clients/node.py

@@ -6,7 +6,7 @@
 
 import requests
 
-from node.blockchain.inner_models import AccountState, Block, Node, SignedChangeRequest
+from node.blockchain.inner_models import AccountState, Block, BlockConfirmation, Node, SignedChangeRequest
 from node.blockchain.types import AccountNumber
 
 logger = logging.getLogger(__name__)
@@ -194,6 +194,11 @@ def send_block(self, /, address: str, block: Union[Block, str]):
         logger.debug('Sending %s to %s', block, address)
         return self.http_post(address, 'blocks', data=block.json() if isinstance(block, Block) else block)
 
+    @with_node
+    def send_block_confirmation(self, /, address: str, block_confirmation: BlockConfirmation):
+        logger.debug('Sending %s to %s', block_confirmation, address)
+        return self.http_post(address, 'block-confirmations', data=block_confirmation.json())
+
     def yield_nodes(self, /, address: str) -> Generator[Node, None, None]:
         for item in self.yield_resource(address, 'nodes', by_limit=LIST_NODES_LIMIT):
             yield Node.parse_obj(item)

node/core/tests/test_node_client.py

@@ -5,9 +5,10 @@
 from requests.exceptions import HTTPError
 
 from node.blockchain.facade import BlockchainFacade
-from node.blockchain.inner_models import Block
+from node.blockchain.inner_models import Block, BlockConfirmation
 from node.blockchain.inner_models import Node as InnerNode
 from node.blockchain.models import Block as ORMBlock
+from node.blockchain.models import BlockConfirmation as ORMBlockConfirmation
 from node.blockchain.models import Node as ORMNode
 from node.blockchain.models import PendingBlock
 from node.blockchain.tests.factories.block import make_block
@@ -114,6 +115,28 @@ def test_send_block_to_address_integration(
         PendingBlock.objects.all().delete()
 
 
+@pytest.mark.usefixtures('rich_blockchain', 'as_confirmation_validator')
+def test_send_confirmation_to_cv(test_server_address, confirmation_validator_key_pair_2, smart_mocked_node_client):
+    assert not ORMBlockConfirmation.objects.exists()
+
+    facade = BlockchainFacade.get_instance()
+    assert facade.get_next_block_number() >= 4
+    block = facade.get_block_by_number(4)
+
+    hash_ = block.make_hash()
+    block_confirmation = BlockConfirmation.create(
+        block.get_block_number(), hash_, confirmation_validator_key_pair_2.private
+    )
+    payload = block_confirmation.json()
+    response = smart_mocked_node_client.send_block_confirmation(test_server_address, block_confirmation)
+
+    assert response.status_code == 201
+    confirmation_orm = ORMBlockConfirmation.objects.get_or_none(number=block_confirmation.get_number(), hash=hash_)
+    assert confirmation_orm
+    assert confirmation_orm.signer == confirmation_validator_key_pair_2.public
+    assert confirmation_orm.body == payload
+
+
 @pytest.mark.django_db
 @pytest.mark.usefixtures('rich_blockchain')
 @pytest.mark.parametrize('block_identifier, block_number', (