Merge pull request #192 from thenewboston-developers/BC-272-add-block-to-blockchain-once-it-gets-enough-confirmations

Unittest submitting block confirmation with invalid signature

Author: dmugtasimov

node/blockchain/tests/test_rest_api/test_block_confirmation.py

@@ -1,4 +1,7 @@
+import json
+
 import pytest
+from django.db import connection
 
 from node.blockchain.facade import BlockchainFacade
 from node.blockchain.inner_models.block_confirmation import BlockConfirmation
@@ -25,3 +28,30 @@ def test_send_confirmation_to_cv(confirmation_validator_key_pair_2, api_client):
     assert confirmation_orm
     assert confirmation_orm.signer == confirmation_validator_key_pair_2.public
     assert confirmation_orm.body == payload
+
+
+@pytest.mark.usefixtures('rich_blockchain', 'as_confirmation_validator')
+def test_confirmation_with_invalid_signature_is_not_accepted(confirmation_validator_key_pair_2, api_client):
+    assert not ORMBlockConfirmation.objects.exists()
+
+    facade = BlockchainFacade.get_instance()
+    assert facade.get_next_block_number() >= 4
+    block = facade.get_block_by_number(4)
+
+    hash_ = block.make_hash()
+    block_confirmation = BlockConfirmation.create(
+        block.get_block_number(), hash_, confirmation_validator_key_pair_2.private
+    )
+    payload_dict = block_confirmation.dict()
+    payload_dict['signature'] = '0' * 128
+    payload = json.dumps(payload_dict)
+    response = api_client.post('/api/block-confirmations/', payload, content_type='application/json')
+
+    assert response.status_code == 400
+    assert response.json() == {'non_field_errors': [{'code': 'invalid', 'message': 'Invalid signature'}]}
+
+    # This is because we have queried the database and nested transactions (save points) are not supported
+    assert connection.needs_rollback
+    connection.set_rollback(False)
+
+    assert not ORMBlockConfirmation.objects.exists()

node/core/custom_djongo/base.py

@@ -68,6 +68,7 @@ def _close(self):
         super()._close()
 
     def _rollback(self):
+        logger.debug('Rolling back...')
         if self.is_autocommit:
             self.on_rollback_callables.clear()
             return
@@ -80,6 +81,7 @@ def _rollback(self):
             on_rollback_callables.popleft()()
 
     def _commit(self):
+        logger.debug('Committing...')
         if self.is_autocommit:
             self.on_rollback_callables.clear()
             return