Fix data race

peter-reinholdt · msricher · commit bb546bf6ec2f · 2025-08-18T10:00:32.000-04:00
diff --git a/pyci/src/hci.cpp b/pyci/src/hci.cpp
@@ -267,11 +267,9 @@ long add_hci(const SQuantOp &ham, WfnType &wfn, const double *coeffs, const doub
         v_threads.emplace_back(&hci_thread<WfnType>, std::ref(ham), std::ref(wfn),
                                std::ref(v_wfns.back()), coeffs, eps, start, end);
     }
-    long n = 0;
-    for (auto &thread : v_threads) {
-        thread.join();
-        wfn.add_dets_from_wfn(v_wfns[n++]);
-    }
+    for (auto &thread : v_threads) thread.join();
+    for (auto &wf : v_wfns) wfn.add_dets_from_wfn(wf);
+
     return wfn.ndet - ndet_old;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -267,11 +267,9 @@ long add_hci(const SQuantOp &ham, WfnType &wfn, const double *coeffs, const doub`
`267`	`267`	`v_threads.emplace_back(&hci_thread<WfnType>, std::ref(ham), std::ref(wfn),`
`268`	`268`	`std::ref(v_wfns.back()), coeffs, eps, start, end);`
`269`	`269`	`}`
`270`		`- long n = 0;`
`271`		`- for (auto &thread : v_threads) {`
`272`		`- thread.join();`
`273`		`- wfn.add_dets_from_wfn(v_wfns[n++]);`
`274`		`- }`
	`270`	`+ for (auto &thread : v_threads) thread.join();`
	`271`	`+ for (auto &wf : v_wfns) wfn.add_dets_from_wfn(wf);`
	`272`	`+`
`275`	`273`	`return wfn.ndet - ndet_old;`
`276`	`274`	`}`
`277`	`275`