Skip to content

Commit 089025c

Browse files
committed
Small edits
1 parent e082693 commit 089025c

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/hyperparameter/autotuning.jl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,13 @@ function update_hyperparameters!(
3434
)
3535
if !isnothing(gp.opt)
3636
f_l, f_μ₀ = hyperparameter_gradient_function(gp, X)
37-
aduse = K_ADBACKEND[] == :auto ? ADBACKEND[] : K_ADBACKEND[]
38-
grads = if aduse == :forward_diff
37+
ad_use = K_ADBACKEND[] == :auto ? ADBACKEND[] : K_ADBACKEND[]
38+
grads = if ad_use == :forward_diff
3939
∇L_ρ_forward(f_l, gp, X)
40-
elseif aduse == :reverse_diff
40+
elseif ad_use == :reverse_diff
4141
∇L_ρ_reverse(f_l, gp, X)
42+
else
43+
error("Uncompatible ADBackend")
4244
end
4345
grads[pr_mean(gp)] = f_μ₀()
4446
apply_grads_kernel_params!(gp.opt, kernel(gp), grads) # Apply gradients to the kernel parameters

src/hyperparameter/forwarddiff_rules.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ function Z_gradient_forward(
4545
opt::InferenceOptimizer,
4646
) where {T<:Real}
4747
gradient_inducing_points = similar(gp.Z.Z)
48-
#preallocation
48+
#pre-allocation
4949
Jmm, Jnm = indpoint_derivative(kernel(gp), gp.Z),
5050
indpoint_derivative(kernel(gp), X, gp.Z)
5151
for j = 1:gp.dim #Iterate over the points
5252
for k = 1:size(gp.Z, 2) #iterate over the dimensions
53-
@views gradient_inducing_points[j, k] =
53+
@views gradient_inducing_points[j, k] .=
5454
f_Z(Jmm[:, :, j, k], Jnm[:, :, j, k], ∇E_μ, ∇E_Σ, i, opt)
5555
end
5656
end
@@ -71,7 +71,7 @@ function Z_gradient_forward(
7171
indpoint_derivative(kernel(gp), gp.Z)
7272
for j = 1:gp.dim #Iterate over the points
7373
for k = 1:size(gp.Z, 2) #iterate over the dimensions
74-
@views Z_gradient[j, k] = f_Z(
74+
@views Z_gradient[j, k] .= f_Z(
7575
Jmm[:, :, j, k],
7676
Jnm[:, :, j, k],
7777
Jab[:, :, j, k],

0 commit comments

Comments
 (0)