Skip to content

SIG table only processed once #458

@argilo

Description

@argilo

libnrsc5 only processes the SIG table the first time it is seen:

nrsc5/src/output.c

Lines 467 to 471 in 20de3b2

if (st->services[0].type != SIG_SERVICE_NONE)
{
// We assume that the SIG will never change, and only process it once.
return;
}

This seems like a bad design, since a station could update its SIG table, or a different station's signal could arrive at the input. When changes to the SIG table occur and libnrsc5 ignores them, error messages like the following begin appearing:

port 0404 not defined in SIG table
port 0402 not defined in SIG table
sequence too large (-835829692)
sequence too large (136251704)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions