Skip to content

Commit 5506d0a

Browse files
committed
fix: register shareman recovery interface in ActiveContext
Add missing shareman->RegisterRecoveryInterface() call in ActiveContext::Start() and corresponding UnregisterRecoveryInterface() in Stop(). Without this, completed sig share sessions are only cleaned up via the 5-second Cleanup() interval instead of promptly via HandleNewRecoveredSig. Under CI load with frozen mocktime, this manifests as flaky test failures in feature_llmq_signing.py and interface_zmq_dash.py. The registration was likely dropped during the sig share refactoring that split share management into a separate shareman object. Closes dashpay#7243
1 parent 65366a4 commit 5506d0a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/active/context.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ void ActiveContext::Start(CConnman& connman, PeerManager& peerman, int16_t worke
7070
cl_signer->Start();
7171
cl_signer->RegisterRecoveryInterface();
7272
is_signer->RegisterRecoveryInterface();
73+
shareman->RegisterRecoveryInterface();
7374

7475
RegisterValidationInterface(cl_signer.get());
7576
}
@@ -78,6 +79,7 @@ void ActiveContext::Stop()
7879
{
7980
UnregisterValidationInterface(cl_signer.get());
8081

82+
shareman->UnregisterRecoveryInterface();
8183
is_signer->UnregisterRecoveryInterface();
8284
cl_signer->UnregisterRecoveryInterface();
8385
cl_signer->Stop();

0 commit comments

Comments
 (0)