Commit 5bef3dc
committed
Merge dashpay#7110: feat(qt): UI refresh (2/n, update "Governance" Tab layout, lifecycle icons, description dialogs, resumable proposal creation)
707ce77 refactor: `qt/proposalwizard.{cpp,h}` -> `qt/proposalcreate.{cpp,h}` (Kittywhiskers Van Gogh)
ce94c3e fix: improve responsiveness in update after user interaction (Kittywhiskers Van Gogh)
3d53afa fix: hold `cs_main` to for consistent state when fetching GovernanceInfo (Kittywhiskers Van Gogh)
a5ae10c fix: correct tooltip display unit bug, IBD status flickering (Kittywhiskers Van Gogh)
6cb7a40 qt: add pending status to signal unbroadcast proposals (Kittywhiskers Van Gogh)
d1e67ff fix: disable governance UI when node runs with `--disablegovernance` (Kittywhiskers Van Gogh)
9fb0c35 qt: make governance clock opt-in (Kittywhiskers Van Gogh)
a0da7de qt: disable proposal buttons until synced, creation button w/o funds (Kittywhiskers Van Gogh)
080c8fb qt: add "Resume Proposal" for post-confirmation broadcast (Kittywhiskers Van Gogh)
2883527 qt: remove remaining pages from proposal wizard (Kittywhiskers Van Gogh)
90e0375 qt: use `SendConfirmationDialog` instead of `QMessageBox` for confirm (Kittywhiskers Van Gogh)
3ca061f qt: drop JSON/hex confirmation page, use description dialogs instead (Kittywhiskers Van Gogh)
16314e7 qt: adjust layout of details page of proposal wizard to resemble DGT (Kittywhiskers Van Gogh)
2d8cffe qt: add blank canvas if there's no proposals to display (Kittywhiskers Van Gogh)
1a1d56e qt: list locally recorded proposals in "Governance" tab (Kittywhiskers Van Gogh)
28b67d3 qt: replace "Active" column with icons that reflect voting status (Kittywhiskers Van Gogh)
5f95737 qt: add voting ballot icon (Kittywhiskers Van Gogh)
af65c0e qt: cleanup proposal context menu, add copy JSON and visit URL options (Kittywhiskers Van Gogh)
552f591 qt: report more proposal information in description, calculate payments (Kittywhiskers Van Gogh)
4295471 qt: report proposal info using QTextEdit instead of an alert with JSON (Kittywhiskers Van Gogh)
f45fe85 qt: use monospace font for hashes in "Governance" tab (Kittywhiskers Van Gogh)
c0d8454 qt: report compact voting status and expanded details in tooltip (Kittywhiskers Van Gogh)
b2b9aa1 qt: change layout of "Governance" tab controls for readability (Kittywhiskers Van Gogh)
9bb7b0a qt: reorder columns in "Governance" tab, make width elastic for key cols (Kittywhiskers Van Gogh)
8257eac qt: decouple chain sync indicator from governance sync (Kittywhiskers Van Gogh)
662703e qt: add governance cycle status bar icon (Kittywhiskers Van Gogh)
a7328e9 qt: add moon phase icons for governance cycle indicator (Kittywhiskers Van Gogh)
c85e5cb qt: move proposal list fetch to thread and use debounce timer (Kittywhiskers Van Gogh)
5af2bb9 qt: expose `NotifyGovernanceChanged` signal to UI code (Kittywhiskers Van Gogh)
a773635 qt: move masternode list fetch logic to thread and use debounce timer (Kittywhiskers Van Gogh)
Pull request description:
## Additional Information
* Depends on dashpay#7112
* Depends on dashpay#7134
| v23.0.2 (cdc5a63) | This PR (WIP code) |
| -------------------- | ------------------- |
|  |  |
|  |  |
|  |  |
| <div align="center">Client doesn't have UI element</div> |  |
| <div align="center">Client doesn't produce a warning</div> |  |
| <div align="center">Client cannot show wallet-stored history</div> |  |
#### Proposal Creation
| v23.0.2 (cdc5a63) | This PR (WIP code) |
| -------------------- | ------------------- |
|  |  |
|  |  |
| <div align="center">See above</div> |  |
|  |  |
| <div align="center">See below</div> |  |
|  |  |
|  | <div align="center">No equivalent page. Broadcasting is made available after relay threshold met.</div> |
|  |  |
|  | <div align="center">No equivalent page</div> |
|  |  |
| <div align="center">No equivalent page</div> |  |
## Breaking Changes
None expected.
## Checklist
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
- [x] I have made corresponding changes to the documentation **(note: N/A)**
- [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
ACKs for top commit:
UdjinM6:
Seems to be working correctly.
Light ACK 707ce77
Tree-SHA512: 66db006c1aca6f9c5081ba6daff9b55ab82528342d3bf1083639f6f3a969773c9c8936cfbc61d190a658e1da6c937fb41ea99b7d7a2a4533e401758045d47b8eFile tree
52 files changed
+2916
-1627
lines changed- contrib/devtools
- src
- governance
- interfaces
- node
- qt
- forms
- res
- css
- icons
- src
- wallet
- test/util/data
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
52 files changed
+2916
-1627
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
81 | | - | |
| 82 | + | |
| 83 | + | |
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
| |||
160 | 162 | | |
161 | 163 | | |
162 | 164 | | |
| 165 | + | |
163 | 166 | | |
164 | | - | |
| 167 | + | |
165 | 168 | | |
166 | 169 | | |
167 | 170 | | |
| |||
211 | 214 | | |
212 | 215 | | |
213 | 216 | | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
214 | 225 | | |
215 | 226 | | |
216 | 227 | | |
| |||
220 | 231 | | |
221 | 232 | | |
222 | 233 | | |
| 234 | + | |
223 | 235 | | |
224 | 236 | | |
| 237 | + | |
225 | 238 | | |
226 | 239 | | |
227 | 240 | | |
| |||
271 | 284 | | |
272 | 285 | | |
273 | 286 | | |
| 287 | + | |
274 | 288 | | |
275 | | - | |
| 289 | + | |
276 | 290 | | |
277 | 291 | | |
278 | 292 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
318 | 319 | | |
319 | 320 | | |
320 | 321 | | |
| 322 | + | |
321 | 323 | | |
322 | 324 | | |
323 | 325 | | |
| |||
530 | 532 | | |
531 | 533 | | |
532 | 534 | | |
533 | | - | |
| 535 | + | |
| 536 | + | |
534 | 537 | | |
535 | 538 | | |
536 | 539 | | |
537 | 540 | | |
538 | | - | |
539 | 541 | | |
540 | 542 | | |
541 | 543 | | |
542 | | - | |
543 | | - | |
544 | 544 | | |
545 | 545 | | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
546 | 555 | | |
547 | 556 | | |
548 | 557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
| 294 | + | |
| 295 | + | |
295 | 296 | | |
296 | 297 | | |
297 | 298 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
155 | 156 | | |
156 | 157 | | |
157 | 158 | | |
| 159 | + | |
158 | 160 | | |
159 | 161 | | |
160 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| |||
133 | 135 | | |
134 | 136 | | |
135 | 137 | | |
136 | | - | |
137 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
138 | 145 | | |
| 146 | + | |
139 | 147 | | |
140 | 148 | | |
141 | 149 | | |
| |||
151 | 159 | | |
152 | 160 | | |
153 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
154 | 168 | | |
155 | 169 | | |
156 | 170 | | |
| |||
175 | 189 | | |
176 | 190 | | |
177 | 191 | | |
| 192 | + | |
178 | 193 | | |
179 | 194 | | |
180 | 195 | | |
| |||
466 | 481 | | |
467 | 482 | | |
468 | 483 | | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
469 | 488 | | |
470 | 489 | | |
471 | 490 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
351 | 352 | | |
352 | 353 | | |
353 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
354 | 358 | | |
355 | 359 | | |
356 | 360 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
61 | 63 | | |
62 | 64 | | |
63 | 65 | | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
118 | 121 | | |
119 | 122 | | |
120 | 123 | | |
| |||
0 commit comments