rpc: add skip_type_check for evo RPCs accepting block hash or height

The new automatic type checking from bitcoin#26039 rejects numeric
heights sent by JSON-RPC clients for RPCArg::Type::STR parameters.
Add skip_type_check to all evo.cpp RPCs where parameters accept both
block hashes (strings) and heights (numbers):

- protx diff: baseBlock, block
- protx listdiff: baseBlock, block
- evodb verify: startBlock, stopBlock
- evodb repair: startBlock, stopBlock

Also simplify ParseBlockIndex by removing the catch-all that was
swallowing the specific 'Block not found' error. ParseBlock already
throws a clear error on bad input, so the catch-all was redundant
and masked useful error messages.

Author: thepastaclaw

src/rpc/evo.cpp

@@ -1604,26 +1604,23 @@ static const CBlockIndex* ParseBlockIndex(const UniValue& v, const ChainstateMan
 {
     AssertLockHeld(::cs_main);
 
-    try {
-        const auto hash{ParseBlock(v, chainman, strName)};
-        const CBlockIndex* pindex = chainman.m_blockman.LookupBlockIndex(hash);
-        if (!pindex) {
-            throw std::runtime_error(strprintf("Block %s with hash %s not found", strName, v.getValStr()));
-        }
-        return pindex;
-    } catch (...) {
-        // Same phrasing as ParseBlock() as it can parse heights
-        throw std::runtime_error(strprintf("%s must be a block hash or chain height and not %s", strName, v.getValStr()));
+    const auto hash{ParseBlock(v, chainman, strName)};
+    const CBlockIndex* pindex = chainman.m_blockman.LookupBlockIndex(hash);
+    if (!pindex) {
+        throw std::runtime_error(strprintf("Block %s with hash %s not found", strName, v.getValStr()));
     }
+    return pindex;
 }
 
 static RPCHelpMan protx_diff()
 {
     return RPCHelpMan{"protx diff",
         "\nCalculates a diff between two deterministic masternode lists. The result also contains proof data.\n",
         {
-            {"baseBlock", RPCArg::Type::STR, RPCArg::Optional::NO, "The starting block hash or height."},
-            {"block", RPCArg::Type::STR, RPCArg::Optional::NO, "The ending block hash or height."},
+            {"baseBlock", RPCArg::Type::STR, RPCArg::Optional::NO, "The starting block hash or height.",
+             RPCArgOptions{.skip_type_check = true}},
+            {"block", RPCArg::Type::STR, RPCArg::Optional::NO, "The ending block hash or height.",
+             RPCArgOptions{.skip_type_check = true}},
             {"extended", RPCArg::Type::BOOL, RPCArg::Optional::OMITTED, "Show additional fields."},
         },
         CSimplifiedMNListDiff::GetJsonHelp(/*key=*/"", /*optional=*/false),
@@ -1663,8 +1660,10 @@ static RPCHelpMan protx_listdiff()
     return RPCHelpMan{"protx listdiff",
                "\nCalculate a full MN list diff between two masternode lists.\n",
                {
-                       {"baseBlock", RPCArg::Type::STR, RPCArg::Optional::NO, "The starting block hash or height."},
-                       {"block", RPCArg::Type::STR, RPCArg::Optional::NO, "The ending block hash or height."},
+                       {"baseBlock", RPCArg::Type::STR, RPCArg::Optional::NO, "The starting block hash or height.",
+                        RPCArgOptions{.skip_type_check = true}},
+                       {"block", RPCArg::Type::STR, RPCArg::Optional::NO, "The ending block hash or height.",
+                        RPCArgOptions{.skip_type_check = true}},
                },
                 RPCResult {
                     RPCResult::Type::OBJ, "", "",
@@ -1839,8 +1838,10 @@ static RPCHelpMan evodb_verify()
         "This is a read-only operation that does not modify the database.\n"
         "If no heights are specified, defaults to the full range from DIP0003 activation to chain tip.\n",
         {
-            {"startBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The starting block hash or height (defaults to DIP0003 activation height)."},
-            {"stopBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The ending block hash or height (defaults to current chain tip)."},
+            {"startBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The starting block hash or height (defaults to DIP0003 activation height).",
+             RPCArgOptions{.skip_type_check = true}},
+            {"stopBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The ending block hash or height (defaults to current chain tip).",
+             RPCArgOptions{.skip_type_check = true}},
         },
         RPCResult{
             RPCResult::Type::OBJ, "", "",
@@ -1877,8 +1878,10 @@ static RPCHelpMan evodb_repair()
         "If verification fails, recalculates diffs from blockchain data and replaces corrupted records.\n"
         "If no heights are specified, defaults to the full range from DIP0003 activation to chain tip.\n",
         {
-            {"startBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The starting block hash or height (defaults to DIP0003 activation height)."},
-            {"stopBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The ending block hash or height (defaults to current chain tip)."},
+            {"startBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The starting block hash or height (defaults to DIP0003 activation height).",
+             RPCArgOptions{.skip_type_check = true}},
+            {"stopBlock", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The ending block hash or height (defaults to current chain tip).",
+             RPCArgOptions{.skip_type_check = true}},
         },
         RPCResult{
             RPCResult::Type::OBJ, "", "",