added unit test to guard against broken logic

Author: Nsikaktopdown

demo-app/src/main/java/co/thepeer/KEYS.kt

@@ -26,7 +26,7 @@ class MainActivity : AppCompatActivity() {
         //initialize ThePeer SDK
         val thePeer = ThePeer.Builder(
             activity = this,
-            amount = BigDecimal(10000.00),
+            amount = BigDecimal(10000000),
             currency = ThePeerCurrency.NGN,
             userReference = getString(R.string.user_reference),
             resultListener = resultListener

demo-app/src/main/java/co/thepeer/MainActivity.kt

@@ -61,19 +61,15 @@ class HostDialogFragment(private val thePeerParam: ThePeerParam) :
 
         activity?.let {
             binding.webViewPeer.addJavascriptInterface(WebInterface { results ->
-                handleRedirect(results)
+                redirectWithResult(results)
             }, "Android")
         }
 
         binding.webViewPeer.loadUrl(transactionUrl)
     }
 
-       private fun handleRedirect(result: ThePeerResult) {
-        val resultData = Intent()
-        resultData.putExtra(ThePeerConstants.TRANSACTION_RESULT, result)
-        activity?.setResult(AppCompatActivity.RESULT_OK, resultData)
-        activity?.finish()
-    }
+
+
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
         val dialog = context?.let { BottomSheetDialog(it, R.style.CustomBottomSheetDialogTheme) }
         binding = FragmentHostDialogBinding.inflate(layoutInflater)
@@ -113,5 +109,4 @@ class HostDialogFragment(private val thePeerParam: ThePeerParam) :
     }
 
 
-
 }

thepeer-android/src/main/java/co/thepeer/sdk/ui/fragments/HostDialogFragment.kt

@@ -21,7 +21,7 @@ internal class WebInterface(private val redirect: (ThePeerResult) -> Unit ) {
     private val DIRECT_CHARGE_INSUFFICIENT_FUNDS = "direct_debit.insufficient_funds"
     private val DIRECT_CHARGE_USER_INSUFFICIENT_FUNDS =
         "direct_debit.user_insufficient_funds"
-    private val DIRECT_DEBIT_SUCCESS = "direct_debit.success"
+    private val DIRECT_CHARGE_SUCCESS = "direct_debit.success"
     private val DIRECT_CHARGE_BUSINESS_DECLINE = "direct_debit.business_decline"
     private val DIRECT_CHARGE_USER_DECLINE = "direct_debit.user_decline"
     private val CHECKOUT_INSUFFICIENT_FUNDS = "checkout.insufficient_funds"
@@ -30,7 +30,7 @@ internal class WebInterface(private val redirect: (ThePeerResult) -> Unit ) {
     private val CHECKOUT_BUSINESS_DECLINE = "checkout.business_decline"
     private val CHECKOUT_USER_DECLINE = "checkout.user_decline"
     private val SEND_CLOSE = "send.close"
-    private val DIRECT_DEBIT_CLOSE = "direct_debit.close"
+    private val DIRECT_CHARGE_CLOSE = "direct_debit.close"
     private val CHECKOUT_CLOSE = "checkout.close"
 
 
@@ -49,7 +49,7 @@ internal class WebInterface(private val redirect: (ThePeerResult) -> Unit ) {
                 redirect(ThePeerResult.Cancelled)
             }
             else -> {
-                redirect(ThePeerResult.Error(Throwable(event.event)))
+                redirect(ThePeerResult.Error(Throwable(event.event.getLastPart())))
             }
         }
 
@@ -73,10 +73,10 @@ internal class WebInterface(private val redirect: (ThePeerResult) -> Unit ) {
     fun handleDirectDebitEvent(event: ThePeerEvent) {
 
         when (event.event) {
-            DIRECT_DEBIT_SUCCESS -> {
+            DIRECT_CHARGE_SUCCESS -> {
                 redirect(ThePeerResult.Success(event.data))
             }
-            DIRECT_DEBIT_CLOSE -> {
+            DIRECT_CHARGE_CLOSE -> {
                 redirect(ThePeerResult.Cancelled)
             }
             else -> {

thepeer-android/src/main/java/co/thepeer/sdk/utils/WebInterface.kt

@@ -54,18 +54,6 @@ class WebInterfaceTest {
 
     }
 
-    @Test
-    fun `handle send event - is error`() {
-        val event = webInterface.convertToGsonFromString(MockData.sendError) as ThePeerEvent
-        webInterface.sendResponse(MockData.sendError)
-        verify {
-            webInterface.handleSendEvent(event)
-        }
-
-        assertEquals("send.user_insufficient_funds", event.event)
-
-    }
-
     @Test
     fun `handle checkout event - success`() {
         val event = webInterface.convertToGsonFromString(MockData.checkoutSuccess) as ThePeerEvent
@@ -92,7 +80,8 @@ class WebInterfaceTest {
 
     @Test
     fun `handle direct debit event - success`() {
-        val event = webInterface.convertToGsonFromString(MockData.directDebitSuccess) as ThePeerEvent
+        val event =
+            webInterface.convertToGsonFromString(MockData.directDebitSuccess) as ThePeerEvent
         webInterface.sendResponse(MockData.directDebitSuccess)
         verify {
             webInterface.handleDirectDebitEvent(event)