fix: Moving and copying of directories using the InMemoryFilesystemAdapter #1482
+88
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @frankdejonge, can we help you in some way to get this merged :) like adding more phpunit tests |
Contributor
|
@frankdejonge could you please provide any feedback? |
|
hey @frankdejonge can we do something to get this forward? 🙂 We have an adaption of this class for three years now in our code, just to fix this bug 🙈 https://github.com/shopware/shopware/blob/trunk/src/Core/Framework/Adapter/Filesystem/MemoryFilesystemAdapter.php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1477
Not sure if the handling of the errors is desired or not. Let me know if there should be something changed.