Skip to content

Correct mistake in documentation #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct mistake in documentation #150

wants to merge 1 commit into from

Conversation

svenk-ct
Copy link

I think the route /api/token wouldn't be matched by the pattern: ^/token$ in the configuration example. So I changed it to just /token. Feel free to close this if I'm misunderstanding something here.

@svenk-ct
Correct mistake in documentation
5894c55 
Make the route in the text the same as in the configuration example.
chalasr
chalasr requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we can remove that api_token firewall entirely and rather use an access_control rule for ^/api/token with roles: PUBLIC_ACCESS. Would you mind trying? (no worry if you don't wan't to make more changes, we'll just leave it up to someone else)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenk-ct @chalasr