fix: Test for availability of doctrine in bundle configuration #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class exists check when configuring doctrine in the bundle
frankdekker
changed the title
ajgarlag
reviewed
Jul 24, 2025
ajgarlag
approved these changes
Jul 24, 2025
chalasr
approved these changes
Jul 24, 2025
|
Hi ! Had the issue when installing the bundle today. (issue here #248) I would also suggest (if doctrine is not required) to not set the default persistence engine to doctrine and instead use 'in_memory' to avoid issue with this : // vendor/league/oauth2-server-bundle/src/DependencyInjection/LeagueOAuth2ServerExtension.php
private function assertRequiredBundlesAreEnabled(ContainerBuilder $container): void
{
$requiredBundles = [
'security' => SecurityBundle::class,
];
if ($container->hasParameter('league.oauth2_server.persistence.doctrine.enabled')) {
$requiredBundles['doctrine'] = DoctrineBundle::class;
}
foreach ($requiredBundles as $bundleAlias => $requiredBundle) {
if (!$container->hasExtension($bundleAlias)) {
throw new \LogicException(\sprintf('Bundle \'%s\' needs to be enabled in your application kernel.', $requiredBundle));
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As doctrine is now a composer suggestion instead of requirement, added
class_existscheck when configuring doctrine in the bundle. If it's absent, do not configure theDoctrineOrmMappingsPass