Merge pull request #91 from timgws/master

Ensure that code has 100% test coverage

Author: delatbabel

tests/Omnipay/Common/CreditCardTest.php

@@ -127,6 +127,13 @@ public function testCustomBrandWorks()
         $this->assertEquals('omniexpress', $this->card->getBrand());
     }
 
+    public function testCustomBrandAddedTwiceReturnsFalse()
+    {
+        $this->assertTrue($this->card->addSupportedBrand('omniexpress', '/^9\d{12}(\d{3})?$/'));
+        $this->assertArrayHasKey('omniexpress', $this->card->getSupportedBrands());
+        $this->assertFalse($this->card->addSupportedBrand('omniexpress', '/^9\d{12}(\d{3})?$/'));
+    }
+
     public function testTitle()
     {
         $this->card->setTitle('Mr.');

tests/Omnipay/Common/Message/AbstractResponseTest.php

@@ -90,6 +90,12 @@ public function testGetRedirectResponseInvalidMethod()
 
         $this->response->getRedirectResponse();
     }
+
+    public function testGetTransactionIdNull()
+    {
+        $this->response = m::mock('\Omnipay\Common\Message\AbstractResponseTest_MockRedirectResponse')->makePartial();
+        $this->assertNull($this->response->getTransactionId());
+    }
 }
 
 class AbstractResponseTest_MockRedirectResponse extends AbstractResponse implements RedirectResponseInterface