Rename create/update/delete with a sufix Card, add tests

Author: pilot

src/Omnipay/Common/AbstractGateway.php

@@ -170,33 +170,33 @@ public function supportsVoid()
     }
 
     /**
-     * Supports Create
+     * Supports CreateCard
      *
      * @return boolean True if this gateway supports the create() method
      */
-    public function supportsCreate()
+    public function supportsCreateCard()
     {
-        return method_exists($this, 'create');
+        return method_exists($this, 'createCard');
     }
 
     /**
-     * Supports Delete
+     * Supports DeleteCard
      *
      * @return boolean True if this gateway supports the delete() method
      */
-    public function supportsDelete()
+    public function supportsDeleteCard()
     {
-        return method_exists($this, 'delete');
+        return method_exists($this, 'deleteCard');
     }
 
     /**
-     * Supports Update
+     * Supports UpdateCard
      *
      * @return boolean True if this gateway supports the update() method
      */
-    public function supportsUpdate()
+    public function supportsUpdateCard()
     {
-        return method_exists($this, 'update');
+        return method_exists($this, 'updateCard');
     }
 
     /**

tests/Omnipay/GatewayTestCase.php

@@ -149,27 +149,39 @@ public function testSupportsVoid()
         }
     }
 
-    public function testSupportsCreate()
+    public function testSupportsCreateCard()
     {
-        $supportsCreate = $this->gateway->supportsCreate();
+        $supportsCreate = $this->gateway->supportsCreateCard();
         $this->assertInternalType('boolean', $supportsCreate);
 
         if ($supportsCreate) {
-            $this->assertInstanceOf('Omnipay\Common\Message\RequestInterface', $this->gateway->create());
+            $this->assertInstanceOf('Omnipay\Common\Message\RequestInterface', $this->gateway->createCard());
         } else {
-            $this->assertFalse(method_exists($this->gateway, 'create'));
+            $this->assertFalse(method_exists($this->gateway, 'createCard'));
         }
     }
 
-    public function testSupportsDelete()
+    public function testSupportsDeleteCard()
     {
-        $supportsDelete = $this->gateway->supportsDelete();
+        $supportsDelete = $this->gateway->supportsDeleteCard();
         $this->assertInternalType('boolean', $supportsDelete);
 
         if ($supportsDelete) {
-            $this->assertInstanceOf('Omnipay\Common\Message\RequestInterface', $this->gateway->delete());
+            $this->assertInstanceOf('Omnipay\Common\Message\RequestInterface', $this->gateway->deleteCard());
         } else {
-            $this->assertFalse(method_exists($this->gateway, 'delete'));
+            $this->assertFalse(method_exists($this->gateway, 'deleteCard'));
+        }
+    }
+
+    public function testSupportsUpdateCard()
+    {
+        $supportsUpdate = $this->gateway->supportsUpdateCard();
+        $this->assertInternalType('boolean', $supportsUpdate);
+
+        if ($supportsUpdate) {
+            $this->assertInstanceOf('Omnipay\Common\Message\RequestInterface', $this->gateway->updateCard());
+        } else {
+            $this->assertFalse(method_exists($this->gateway, 'updateCard'));
         }
     }
 
@@ -290,9 +302,26 @@ public function testVoidParameters()
         }
     }
 
-    public function testCreateParameters()
+    public function testCreateCardParameters()
+    {
+        if ($this->gateway->supportsCreateCard()) {
+            foreach ($this->gateway->getDefaultParameters() as $key => $default) {
+                // set property on gateway
+                $getter = 'get'.ucfirst($key);
+                $setter = 'set'.ucfirst($key);
+                $value = uniqid();
+                $this->gateway->$setter($value);
+
+                // request should have matching property, with correct value
+                $request = $this->gateway->createCard();
+                $this->assertSame($value, $request->$getter());
+            }
+        }
+    }
+
+    public function testDeleteCardParameters()
     {
-        if ($this->gateway->supportsCreate()) {
+        if ($this->gateway->supportsDeleteCard()) {
             foreach ($this->gateway->getDefaultParameters() as $key => $default) {
                 // set property on gateway
                 $getter = 'get'.ucfirst($key);
@@ -301,15 +330,15 @@ public function testCreateParameters()
                 $this->gateway->$setter($value);
 
                 // request should have matching property, with correct value
-                $request = $this->gateway->create();
+                $request = $this->gateway->deleteCard();
                 $this->assertSame($value, $request->$getter());
             }
         }
     }
 
-    public function testDeleteParameters()
+    public function testUpdateCardParameters()
     {
-        if ($this->gateway->supportsDelete()) {
+        if ($this->gateway->supportsUpdateCard()) {
             foreach ($this->gateway->getDefaultParameters() as $key => $default) {
                 // set property on gateway
                 $getter = 'get'.ucfirst($key);
@@ -318,7 +347,7 @@ public function testDeleteParameters()
                 $this->gateway->$setter($value);
 
                 // request should have matching property, with correct value
-                $request = $this->gateway->delete();
+                $request = $this->gateway->updateCard();
                 $this->assertSame($value, $request->$getter());
             }
         }