Workaround limitations of empty() in PHP < 5.5

Andrew Keynes · Andrew Keynes · commit 1ae9042dce59 · 2015-05-04T14:47:11.000+09:30
diff --git a/src/Message/SecureXMLAbstractRequest.php b/src/Message/SecureXMLAbstractRequest.php
@@ -31,7 +31,9 @@ public function setMessageId($value)
      */
     public function getMessageId()
     {
-        if (empty($this->getParameter('messageId'))) {
+        $messageId = $this->getParameter('messageId');
+
+        if (empty($messageId)) {
             $this->setMessageId(substr(md5(microtime()), 0, 30));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,9 @@ public function setMessageId($value)`
`31`	`31`	`*/`
`32`	`32`	`public function getMessageId()`
`33`	`33`	`{`
`34`		`- if (empty($this->getParameter('messageId'))) {`
	`34`	`+ $messageId = $this->getParameter('messageId');`
	`35`	`+`
	`36`	`+ if (empty($messageId)) {`
`35`	`37`	`$this->setMessageId(substr(md5(microtime()), 0, 30));`
`36`	`38`	`}`
`37`	`39`