Update required phpunit and codesniffer versions?

[thinkspill]

Hello! Would it be possible to bump the version restrictions up to ~4 for PHPUnit and ~2 for squizlabs/php_codesniffer?

[kosssi]

👍

[laverboy]

Yes please

[barryvdh]

I've already updated Codesniffer in v3: https://github.com/thephpleague/omnipay-tests/blob/3.0/composer.json
Is ~4 of phpunit compatible with 3?

[leith]

Would be good to see mockery updated to ~0.9 as well.

PHPUnit has also released past v5.0 at this point, although 5.0.0 removed support for PHP 5.3, PHP 5.4, and PHP 5.5.

[delatbabel]

We need to have support for PHP versions back to 5.4 at least for Omnipay 2.0. That includes any test frameworks, etc.

[leith]

Mockery 0.9.4 has 5.3 as the minimum, so no worries there. If support for PHP <= 5.5 in PHPUnit isn't removed until v5.0, then updating to 4.x should be fine.

[hkdobrev]

👍 for updating phpunit/phpunit to ^4.0

[digibeuk]

we would really like to have php 7.2. compatibility for omnipay tests, is this still in the works or do you need any help?

[barryvdh]

Isn't that supported with v3 then?

[davidbankes]

#13

This permits the old version of phpunit if required for compatibility. This allows me to run the tests in php7.2. There is a deprecated notice, but the tests run fine. (I need this for a bugfix for omnipay/firstdata, which is still omnipay 2 only.)

[davidbankes]

Not to pester, but with #13 merged, do you think we should have a tag (v2.1.1)? The test suite for v2 is now compatible with php7.2. I think that would resolve this issue.

[eduarguz]

Hi, is phpunit 7 supported?

[davidbankes]

yes, on v2.1.1.

see #13

[eduarguz]

@davidbankes thanks for your quick answer, but now I am a bit confused
is omnipay/tests:2.* meant to be used with omnipay/common:^3 or with ^2?

I was using them both on ^3 versions

[3ynm]

PHPUnit 6 reached its EOL last month D: https://phpunit.de/supported-versions.html