Merge pull request #139 from brummbar/isbefore-period-bounds

Consider bounds when checking if a period is before another.

Author: nyamsprod

src/Period.php

@@ -488,7 +488,7 @@ public function durationLessThan(Period|Duration|DateInterval|string $duration):
     public function isBefore(Period|DatePoint|DateTimeInterface|string $timeSlot): bool
     {
         if ($timeSlot instanceof self) {
-            return $this->endDate <= $timeSlot->startDate;
+            return $this->endDate <= $timeSlot->startDate && !$this->meetsOnStart($timeSlot);
         }
 
         $datePoint = self::filterDatePoint($timeSlot);

src/PeriodRelationTest.php

@@ -90,11 +90,11 @@ public static function isBeforeProvider(): array
             'exclude start date is before interval' => [
                 'interval' => Period::after('2012-01-01', '1 MONTH', Bounds::ExcludeStartIncludeEnd),
                 'input' => Period::fromMonth(2012, 2),
-                'expected' => true,
+                'expected' => false,
             ],
             'exclude start date is not before interval' => [
                 'interval' => Period::after('2012-01-01', '1 MONTH', Bounds::ExcludeStartIncludeEnd),
-                'input' => Period::fromMonth(2012, 2),
+                'input' => Period::fromMonth(2012, 3),
                 'expected' => true,
             ],
             'exclude start date abuts interval start date' => [
@@ -155,10 +155,10 @@ public static function isAfterProvider(): array
             'exclude start date is before interval' => [
                 'interval' => Period::fromMonth(2012, 2),
                 'input' => Period::after('2012-01-01', '1 MONTH', Bounds::ExcludeStartIncludeEnd),
-                'expected' => true,
+                'expected' => false,
             ],
             'exclude start date is not before interval' => [
-                'interval' => Period::fromMonth(2012, 2),
+                'interval' => Period::fromMonth(2012, 3),
                 'input' => Period::after('2012-01-01', '1 MONTH', Bounds::ExcludeStartIncludeEnd),
                 'expected' => true,
             ],