Skip to content
This repository was archived by the owner on Nov 26, 2022. It is now read-only.

Commit 00a7c63

Browse files
committed
Improve Github integration
1 parent f1227b6 commit 00a7c63

File tree

9 files changed

+109
-54
lines changed

9 files changed

+109
-54
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ We accept bug reports via issues created on [Github](https://github.com/thephple
2222

2323
## Pull Request
2424

25-
We accept contributions via Pull Requests on [Github](https://github.com/thephpleague/uri-query-parser/pull).
25+
We accept contributions via Pull Requests on [Github](https://github.com/thephpleague/uri-query-parser/pulls).
2626

27-
- **[PSR-2 Coding Standard](http://www.php-fig.org/psr/psr-2/)** - Your patch won't be accepted if it doesn't pass the package coding style test suite.
27+
- **[PSR-2 Coding Standard](https://www.php-fig.org/psr/psr-2/)** - Your patch won't be accepted if it doesn't pass the package coding style test suite.
2828

2929
- **Add tests!** - Your patch won't be accepted if it doesn't have tests.
3030

@@ -38,12 +38,10 @@ We accept contributions via Pull Requests on [Github](https://github.com/thephpl
3838

3939
- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting.
4040

41-
42-
## Running Tests
41+
- **Run the test suite** - If you want your PR to be reviewed ASAP please consider running this command before submitting it to make sure all tests are still passing and that the package coding style is respected.
4342

4443
``` bash
4544
$ composer test
4645
```
4746

48-
49-
**Happy coding**!
47+
**Happy coding**!

.github/ISSUE_TEMPLATE.md

Lines changed: 0 additions & 22 deletions
This file was deleted.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
---
2+
name: 🐛 Bug Report
3+
about: Something is broken? 🔨
4+
---
5+
6+
### Bug Report
7+
8+
_(Fill in the relevant information below to help triage your issue.)_
9+
10+
| Information | Description |
11+
|--------------|---------|
12+
| Version | |
13+
| PHP version | |
14+
| OS Platform | |
15+
16+
#### Summary
17+
18+
_(Please explain in plain english your bug)_
19+
20+
#### Standalone code, or other way to reproduce the problem
21+
22+
_(Please complete the text below to help us fix the issue)_
23+
24+
#### Expected result
25+
26+
_(What was the expected (correct) behavior?)_
27+
28+
#### Actual result
29+
30+
_(What is the current (buggy) behavior?)_
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
name: 🎉 Feature Request
3+
about: Do you have a new feature in mind?
4+
---
5+
6+
### Feature Request
7+
8+
| Q | A
9+
|------------ | ------
10+
| New Feature | yes
11+
| BC Break | yes/no
12+
13+
14+
#### Proposal
15+
16+
_(Please explain in plain english the feature you would like to see implemented.)_

.github/ISSUE_TEMPLATE/Question.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
name: ❓ Question
3+
about: Are you unsure about something?
4+
---
5+
6+
_(Fill in the relevant information below to help triage your issue.)_
7+
8+
| Q | A
9+
|------------ | ------
10+
| Version | x.y.z
11+
12+
### Question
13+
14+
_(Please explain in plain english your question)_

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
name: 🐛 Bug Report
3+
about: Something is broken and you have a failing Unit Test? 🔨
4+
---
5+
6+
### Bug Report
7+
8+
_(Fill in the relevant information below to help triage your issue.)_
9+
10+
| Information | Description |
11+
|--------------|---------|
12+
| Version | |
13+
| PHP version | |
14+
| OS Platform | |
15+
16+
#### Summary
17+
18+
_(Please explain in plain english the failing test)_
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
name: 🎉 New Feature
3+
about: You have implemented some neat idea that you want to make part of the URI Query Parser ? 🎩
4+
---
5+
6+
<!--
7+
Thank you for submitting new feature!
8+
Pick the target branch based according to these criteria:
9+
* submitting a bugfix: target the lowest active stable branch: 2.6
10+
* submitting a new feature: target the master branch.
11+
* submitting a BC-breaking change: target the master branch
12+
-->
13+
14+
### New Feature
15+
16+
_(Fill in the relevant information below to help triage your issue.)_
17+
18+
| Q | A
19+
|------------ | ------
20+
| New Feature | yes/no
21+
| BC Break | yes/no
22+
23+
24+
#### Proposal
25+
26+
_(Please explain in plain english the feature you would like to see implemented.)_

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
}
2121
] ,
2222
"require": {
23-
"php": ">=7.2.0"
23+
"php": "^7.2"
2424
},
2525
"require-dev": {
2626
"friendsofphp/php-cs-fixer": "^2.3",

0 commit comments

Comments
 (0)