Skip to content

Commit e0519da

Browse files
committed
Support PHP 7, PHPUnit 6 & DBUnit 3
1 parent ddbb54a commit e0519da

File tree

7 files changed

+38
-19
lines changed

7 files changed

+38
-19
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
},
2222
"require": {
2323
"slim/slim": "~3.1",
24-
"phpunit/phpunit": "^4.8|5.*",
25-
"phpunit/dbunit": "2.*",
24+
"phpunit/phpunit": "^4.8|5.*|6.*",
25+
"phpunit/dbunit": "2.*|3.*",
2626
"illuminate/database": ">=4.0"
2727
},
2828
"require-dev": {

src/There4/Slim/Test/WebDbTestCase.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@
22

33
namespace There4\Slim\Test;
44

5-
class WebDbTestCase extends \PHPUnit_Extensions_Database_TestCase
5+
use PDO;
6+
use PHPUnit\DbUnit\TestCase;
7+
use PHPUnit\DbUnit\DataSet\QueryDataSet;
8+
9+
class WebDbTestCase extends TestCase
610
{
711
/** @var \Slim\App */
812
protected $app;
@@ -33,16 +37,16 @@ public function getSlimInstance()
3337
public function getConnection()
3438
{
3539
if ($this->conn === null) {
36-
$pdo = new \PDO('sqlite::memory:');
40+
$pdo = new PDO('sqlite::memory:');
3741
$this->conn = $this->createDefaultDBConnection($pdo, ':memory:');
3842
}
3943
return $this->conn;
4044
}
4145

4246
public function getDataSet()
4347
{
44-
return new \PHPUnit_Extensions_Database_DataSet_QueryDataSet(
45-
$this->getConnection()
46-
);
48+
return new QueryDataSet(
49+
$this->getConnection()
50+
);
4751
}
4852
}

src/There4/Slim/Test/WebTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace There4\Slim\Test;
44

5-
class WebTestCase extends \PHPUnit_Framework_TestCase
5+
class WebTestCase extends \PHPUnit\Framework\TestCase
66
{
77
/** @var \Slim\App */
88
protected $app;

tests/There4Test/Slim/Test/WebDbTestCaseTest.php

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@
22

33
namespace There4Test\Slim\Test;
44

5+
use PHPUnit\Framework\TestCase;
56
use There4\Slim\Test\WebDbTestCase;
67

7-
class WebDbTestCaseTest extends \PHPUnit_Framework_TestCase
8+
class WebDbTestCaseTest extends TestCase
89
{
910
public function testExtendsDbUnit()
1011
{
1112
$testCase = new WebDbTestCase();
1213
self::assertInstanceOf(
13-
'\PHPUnit_Extensions_Database_TestCase',
14+
'\PHPUnit\DbUnit\TestCase',
1415
$testCase
1516
);
1617
}
@@ -46,10 +47,10 @@ public function testGetSlimInstance()
4647

4748
public function testGetDataset()
4849
{
49-
$testCase = new WebDbTestCase();
50-
$actualDataSet = get_class($testCase->getDataSet());
51-
$expectedDataSet = 'PHPUnit_Extensions_Database_DataSet_QueryDataSet';
52-
53-
self::assertEquals($expectedDataSet, $actualDataSet);
50+
$testCase = new WebDbTestCase();
51+
self::assertInstanceOf(
52+
'\PHPUnit\DbUnit\DataSet\QueryDataSet',
53+
$testCase->getDataSet()
54+
);
5455
}
5556
}

tests/There4Test/Slim/Test/WebTestCaseTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace There4Test\Slim\Test;
44

5+
use PHPUnit\Framework\TestCase;
56
use There4\Slim\Test\WebTestCase;
67

7-
class WebTestCaseTest extends \PHPUnit_Framework_TestCase
8+
class WebTestCaseTest extends TestCase
89
{
910
public function testSetup()
1011
{

tests/There4Test/Slim/Test/WebTestClientTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
namespace There4Test\Slim\Test;
44

5+
use Exception;
6+
use PHPUnit\Framework\TestCase;
57
use Slim\App;
68
use There4\Slim\Test\WebTestCase;
79
use There4\Slim\Test\WebTestClient;
810

9-
class WebTestClientTest extends \PHPUnit_Framework_TestCase
11+
class WebTestClientTest extends TestCase
1012
{
1113
/**
1214
* @var App
@@ -144,7 +146,7 @@ private function getValidUri()
144146
public function testInternalError()
145147
{
146148
$this->getSlimInstance()->get('/internalerror', function ($request, $response, $args) {
147-
throw new \Exception('Testing /internalerror.');
149+
throw new Exception('Testing /internalerror.');
148150
return $response;
149151
});
150152

tests/bootstrap.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,16 @@ class_alias('\PHPUnit_Framework_TestCase', 'PHPUnit\Framework\TestCase');
1212
// Backward compatibility for DBUnit 2
1313
if (!class_exists('\PHPUnit\DbUnit\TestCase') &&
1414
class_exists('\PHPUnit_Extensions_Database_TestCase')) {
15-
class_alias('\PHPUnit_Extensions_Database_TestCase', 'PHPUnit\DbUnit\TestCase');
15+
class_alias(
16+
'\PHPUnit_Extensions_Database_TestCase',
17+
'PHPUnit\DbUnit\TestCase'
18+
);
19+
}
20+
21+
if (!class_exists('\PHPUnit\DbUnit\DataSet\QueryDataSet') &&
22+
class_exists('\PHPUnit_Extensions_Database_DataSet_QueryDataSet')) {
23+
class_alias(
24+
'\PHPUnit_Extensions_Database_DataSet_QueryDataSet',
25+
'PHPUnit\DbUnit\DataSet\QueryDataSet'
26+
);
1627
}

0 commit comments

Comments
 (0)