chore: also upload test run error logs

Author: theseion

.github/workflows/configure-rules-for-test.sh

@@ -22,7 +22,7 @@ while read -r line; do
   test_value="$(cut -d'|' -f5 <<< "${line}")"
 
   if ! grep -q "${var_name}" "${readme_file}"; then
-    echo "Failed to find environment variable `${var_name}` in README."
+    echo "Failed to find environment variable '${var_name}' in README."
     exit 1
   fi
 

.github/workflows/verifyimage.yml

@@ -147,3 +147,12 @@ jobs:
             --log-file "tests/logs/${modsec_version}/error.log" \
             --overrides "tests/regression/${backend}-overrides.yaml" \
             --show-failures-only
+
+      - name: Upload logs
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: ${{ matrix.target }}-error.log
+          path: "crs/tests/logs/${{ contains(matrix.target, 'apache') && 'modsec2-apache' || 'modsec3-nginx' }}/error.log"
+          retention-days: 7
+          overwrite: true