Skip to content

Commit e79c6f1

Browse files
eurofunlgirdwood
authored andcommitted
logger: fix typos, long lines
Apart from the title content: While using 'filtration' and 'filtering' interchangeably is not a real error, consistent use of one or the other seems better. Changed to 'filtering'. Signed-off-by: Alexander Boehm <[email protected]>
1 parent c944238 commit e79c6f1

File tree

1 file changed

+10
-7
lines changed
  • developer_guides/debugability/logger

1 file changed

+10
-7
lines changed

developer_guides/debugability/logger/index.rst

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -204,18 +204,21 @@ Instance descriptions can have one of the following forms:
204204
- ``X.*`` - each component on selected pipeline *X*
205205
- ``X.Y`` - component on pipeline *X* with id *Y*
206206

207-
Trace level changes works in the same order as options given in a command line, and a new set overwrites old values. It allows you to easily enable verbose logs only for selected components and keep the lowest possible log level (critical) for others, as shown in the following example:
207+
Trace level changes work in the same order as options given in a command line, and a new set overwrites old values.
208+
It allows you to easily enable verbose logs only for selected components and keep the lowest possible log level (critical) for
209+
others, as shown in the following example:
208210

209211
sof-logger -l ldc_file -t -Fcritical=* -Fverbose="dai*, volume1.1"
210212

211213
A similar example may be prepared for components on a particular pipeline:
212214

213-
sof-loggerr -l ldc_file -t -Fc=* -Fv=*1.*
215+
sof-logger -l ldc_file -t -Fc=* -Fv=*1.*
214216

215217
.. note::
216218
To track a verbose message, select the "Trace verbose" option under the "Trace" menu from the firmware build.
217219

218-
Active trace filters are stored in the firmware runtime memory, so after a firmware restart (such as after power gating in sleep mode) filters settings will be reset.
220+
Active trace filters are stored in the firmware runtime memory, so after a firmware restart (such as after power gating
221+
in sleep mode) filters settings will be reset.
219222

220223
Consider disabling power gating during your debug session by entering the following:
221224

@@ -231,7 +234,7 @@ Consider disabling power gating during your debug session by entering the follow
231234
232235
cat /sys/devices/pci0000\:00/0000\:$(lspci -nn | grep "audio controller" | awk '{print $1;}')/power/runtime_status
233236
234-
The logger trace filtration affects only traces sent after the filter setup,
237+
The logger trace filtering affects only traces sent after the filter setup,
235238
so traces already stored on the kernel side are not affected.
236239

237240
Filters are set up incrementally, so when loggers are run twice with
@@ -242,11 +245,11 @@ default state, a firmware reset is needed.
242245
Detailed description
243246
--------------------
244247

245-
The filtration mechanism occurs on the firmware side so, after changing the
246-
log level to verbose for each component, the DSP can be overhelmed by
248+
The filtering mechanism occurs on the firmware side so, after changing the
249+
log level to verbose for each component, the DSP can be overwhelmed by
247250
tracing.
248251

249-
Core functionality is provided by the DSP, so filtration does not work in
252+
Core functionality is provided by the DSP, so filtering does not work in
250253
offline mode - during conversion in a previously saved input file.
251254

252255
Communication between the firmware and logger is occurs through driver

0 commit comments

Comments
 (0)