Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Commit c602e95

Browse files
authored
Merge pull request #491 from thestormforge/revert-name-label-change
Reverting the name label change
2 parents aaf6c39 + df744b9 commit c602e95

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

cli/internal/commands/grant_permissions/generator.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ func (o *GeneratorOptions) generateClusterRoleBinding(roleRef *rbacv1.RoleRef, s
239239
return &rbacv1.ClusterRoleBinding{
240240
ObjectMeta: metav1.ObjectMeta{
241241
Name: roleRef.Name + "binding",
242-
Labels: map[string]string{"app.kubernetes.io/name": "optimize-controller"},
242+
Labels: map[string]string{"app.kubernetes.io/name": "optimize"},
243243
},
244244
Subjects: []rbacv1.Subject{*subject},
245245
RoleRef: *roleRef,
@@ -272,7 +272,7 @@ func (o *GeneratorOptions) generateRoleBindings(ctx context.Context, roleRef *rb
272272
ObjectMeta: metav1.ObjectMeta{
273273
Name: roleRef.Name + "binding",
274274
Namespace: scanner.Text(),
275-
Labels: map[string]string{"app.kubernetes.io/name": "optimize-controller"},
275+
Labels: map[string]string{"app.kubernetes.io/name": "optimize"},
276276
},
277277
Subjects: []rbacv1.Subject{*subject},
278278
RoleRef: *roleRef,
@@ -285,7 +285,7 @@ func (o *GeneratorOptions) generateRoleBindings(ctx context.Context, roleRef *rb
285285
ObjectMeta: metav1.ObjectMeta{
286286
Name: "optimize-manager-rolebinding",
287287
Namespace: scanner.Text(),
288-
Labels: map[string]string{"app.kubernetes.io/name": "optimize-controller"},
288+
Labels: map[string]string{"app.kubernetes.io/name": "optimize"},
289289
},
290290
Subjects: []rbacv1.Subject{*subject},
291291
RoleRef: rbacv1.RoleRef{

cli/internal/commands/initialize/initialize.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (o *Options) Initialize(ctx context.Context) error {
5757
}
5858

5959
// Run `kubectl apply` to install the product
60-
// TODO Handle upgrades with "--prune", "--selector", "app.kubernetes.io/name=optimize-controller,app.kubernetes.io/managed-by=%s"
60+
// TODO Handle upgrades with "--prune", "--selector", "app.kubernetes.io/name=optimize,app.kubernetes.io/managed-by=%s"
6161
kubectlApply, err := o.Config.Kubectl(ctx, "apply", "-f", "-")
6262
if err != nil {
6363
return err

config/default/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namePrefix: optimize-
1010

1111
# Labels to add to all resources and selectors.
1212
commonLabels:
13-
app.kubernetes.io/name: optimize-controller
13+
app.kubernetes.io/name: optimize
1414

1515
resources:
1616
- ../crd

0 commit comments

Comments
 (0)