Rename stuff to ada case

thetarnav · thetarnav · commit dc5921369abf · 2025-06-14T12:10:54.000+02:00
diff --git a/extension/src/background.ts b/extension/src/background.ts
@@ -9,8 +9,8 @@ It has to coordinate the communication between the different scripts based on th
 import {assert} from '@solid-devtools/shared/utils'
 
 import {
-    Place_Name, ConnectionName, type Port,
-    type DetectionState, type Versions, type Message,
+    Place_Name, Connection_Name, type Port,
+    type Detection_State, type Versions, type Message,
     port_on_message, port_post_message, port_post_message_obj,
     place_error, place_log,
     ICONS_BLUE, ICONS_GRAY,
@@ -58,7 +58,7 @@ type Script_Devtools = {
 type Script_Content = {
     tab_id:    Tab_Id
     port:      Port
-    detection: DetectionState | null
+    detection: Detection_State | null
     versions:  Versions       | null
 }
 
@@ -102,7 +102,7 @@ function on_connected(port: Port) {
     place_log(Place_Name.Background, 'Port connected', port)
 
     switch (port.name) {
-    case ConnectionName.Popup: {
+    case Connection_Name.Popup: {
         popup = {port}
 
         let content = script_content_map.get(active_tab_id)
@@ -113,7 +113,7 @@ function on_connected(port: Port) {
 
         break
     }
-    case ConnectionName.Content: {
+    case Connection_Name.Content: {
         let tab_id = get_assert_tab_id(port, Place_Name.Content)
 
         let content: Script_Content = {
@@ -132,7 +132,7 @@ function on_connected(port: Port) {
 
         break
     }
-    case ConnectionName.Devtools: {
+    case Connection_Name.Devtools: {
 
         let devtools: Script_Devtools = {port, tab_id: active_tab_id}
         script_devtools_map.set(active_tab_id, devtools)
@@ -144,7 +144,7 @@ function on_connected(port: Port) {
 
         break
     }
-    case ConnectionName.Panel: {
+    case Connection_Name.Panel: {
 
         let panel: Script_Panel = {port, tab_id: active_tab_id}
         script_panel_map.set(active_tab_id, panel)
@@ -167,11 +167,11 @@ function on_disconnected(port: Port) {
     place_log(Place_Name.Background, 'Port disconnected', port)
 
     switch (port.name) {
-    case ConnectionName.Popup: {
+    case Connection_Name.Popup: {
         popup = undefined
         break
     }
-    case ConnectionName.Content: {
+    case Connection_Name.Content: {
         let tab_id = get_assert_tab_id(port, Place_Name.Content)
 
         let content = script_content_map.get(tab_id)!
@@ -202,7 +202,7 @@ function on_disconnected(port: Port) {
 
         break
     }
-    case ConnectionName.Devtools: {
+    case Connection_Name.Devtools: {
         script_devtools_map.delete(active_tab_id)
 
         let content = script_content_map.get(active_tab_id)
@@ -212,7 +212,7 @@ function on_disconnected(port: Port) {
 
         break
     }
-    case ConnectionName.Panel: {
+    case Connection_Name.Panel: {
         script_panel_map.delete(active_tab_id)
 
         let content = script_content_map.get(active_tab_id)
@@ -230,10 +230,10 @@ function on_message(port: Port, e: Message) {
     DEV: {place_log(Place_Name.Background, 'Message', e, 'from', port)}
 
     switch (port.name) {
-    case ConnectionName.Popup: {
+    case Connection_Name.Popup: {
         break
     }
-    case ConnectionName.Content: {
+    case Connection_Name.Content: {
         let tab_id = get_assert_tab_id(port, Place_Name.Content)
 
         let content = script_content_map.get(tab_id)
@@ -282,10 +282,10 @@ function on_message(port: Port, e: Message) {
 
         break
     }
-    case ConnectionName.Devtools: {
+    case Connection_Name.Devtools: {
         break
     }
-    case ConnectionName.Panel: {
+    case Connection_Name.Panel: {
 
         // Forward all messages to Content
         let content = script_content_map.get(active_tab_id)
diff --git a/extension/src/content.ts b/extension/src/content.ts
@@ -10,11 +10,11 @@ This script is injected into every page and is responsible for:
 */
 
 import {
-    Place_Name, ConnectionName,
+    Place_Name, Connection_Name,
     port_on_message, port_post_message_obj, port_post_message,
     window_post_message_obj, window_on_message, window_post_message,
     place_error, place_log,
-    type Message, type Versions, type DetectionState,
+    type Message, type Versions, type Detection_State,
 } from './shared.ts'
 
 // @ts-expect-error ?script&module query ensures output in ES module format and only import the script path
@@ -68,7 +68,7 @@ let versions: Versions = {
     extension:       chrome.runtime.getManifest().version,
     client_expected: import.meta.env.EXPECTED_CLIENT,
 }
-let detection: DetectionState | null = null
+let detection: Detection_State | null = null
 
 let connecting = false
 function connect_port() {
@@ -78,7 +78,7 @@ function connect_port() {
     DEV: {place_log(Place_Name.Content, 'Attempting to connect port...')}
 
     try {
-        let new_port = chrome.runtime.connect({name: ConnectionName.Content})
+        let new_port = chrome.runtime.connect({name: Connection_Name.Content})
         bg_port = new_port
         DEV: {place_log(Place_Name.Content, 'Port connected successfully')}
 
diff --git a/extension/src/devtools.ts b/extension/src/devtools.ts
@@ -8,7 +8,7 @@ It connects to the background script.
 */
 
 import {
-    Place_Name, ConnectionName, port_on_message, ICON_OUTLINE_32,
+    Place_Name, Connection_Name, port_on_message, ICON_OUTLINE_32,
     place_error, place_log,
 } from './shared.ts'
 
@@ -17,7 +17,7 @@ place_log(Place_Name.Devtools, 'loaded.')
 
 
 // Create a connection to the background page
-const port = chrome.runtime.connect({name: ConnectionName.Devtools})
+const port = chrome.runtime.connect({name: Connection_Name.Devtools})
 
 // Firefox requires absolute path
 const PATH_PREFIX = import.meta.env.BROWSER === 'firefox' ? '/' : ''
diff --git a/extension/src/panel.tsx b/extension/src/panel.tsx
@@ -8,7 +8,7 @@ import * as frontend from '@solid-devtools/frontend'
 import * as debug    from '@solid-devtools/debugger/types'
 
 import {
-    ConnectionName, Place_Name, port_on_message, port_post_message_obj,
+    Connection_Name, Place_Name, port_on_message, port_post_message_obj,
     place_log, place_error, place_warn,
     type Message, type Versions,
 } from './shared.ts'
@@ -58,7 +58,7 @@ function App() {
         place_log(Place_Name.Panel, 'Attempting to connect port...')
 
         try {
-            let new_port = chrome.runtime.connect({name: ConnectionName.Panel})
+            let new_port = chrome.runtime.connect({name: Connection_Name.Panel})
             setPort(new_port)
             place_log(Place_Name.Panel, 'Port connected successfully')
 
diff --git a/extension/src/popup.tsx b/extension/src/popup.tsx
@@ -4,20 +4,20 @@ import * as s from 'solid-js'
 import {render} from 'solid-js/web'
 
 import {
-    ConnectionName, Place_Name, port_on_message,
+    Connection_Name, Place_Name, port_on_message,
     place_log,
-    type DetectionState, type Versions,
+    type Detection_State, type Versions,
 } from './shared.ts'
 
 import './popup.css'
 
 place_log(Place_Name.Popup, 'loaded.')
 
 // Create a connection to the background page
-const port = chrome.runtime.connect({name: ConnectionName.Popup})
+const port = chrome.runtime.connect({name: Connection_Name.Popup})
 
 const [versions, setVersions] = s.createSignal<Versions | null>(null)
-const empty_detection_state: DetectionState = {
+const empty_detection_state: Detection_State = {
     solid:    false,
     solid_dev: false,
     setup: false,
diff --git a/extension/src/real_world.ts b/extension/src/real_world.ts
@@ -12,7 +12,7 @@
 import * as detect from '@solid-devtools/shared/detect'
 
 import {
-    Place_Name, type DetectionState,
+    Place_Name, type Detection_State,
     window_post_message, window_on_message, window_post_message_obj,
     place_log, place_warn,
 } from './shared.ts'
@@ -22,7 +22,7 @@ DEV: {place_log(Place_Name.Detector_Real_World, 'loaded.')}
 
 function main() {
 
-    const detect_state: DetectionState = {
+    const detect_state: Detection_State = {
         solid:     false,
         solid_dev: false,
         setup:     false,
@@ -63,7 +63,7 @@ function main() {
     function update_detected() {
 
         window_post_message('Detected', detect_state)
-        
+
         if (!debugger_attached && detect_state.setup) {
             debugger_attached = true
             attach_debugger()
@@ -171,4 +171,4 @@ Expected version: ${title}@${expected_str}`)
 }
 
 
-main()
+main()
diff --git a/extension/src/shared.ts b/extension/src/shared.ts
@@ -46,14 +46,14 @@ export const enum Place_Name {
     Detector_Real_World = 'Detector_Real_World',
 }
 
-export const enum ConnectionName {
+export const enum Connection_Name {
     Content  = DEVTOOLS_ID_PREFIX+Place_Name.Content,
     Devtools = DEVTOOLS_ID_PREFIX+Place_Name.Devtools,
     Popup    = DEVTOOLS_ID_PREFIX+Place_Name.Popup,
     Panel    = DEVTOOLS_ID_PREFIX+Place_Name.Panel,
 }
 
-export type DetectionState = {
+export type Detection_State = {
     solid:     boolean
     solid_dev: boolean
     setup:     boolean
@@ -66,11 +66,10 @@ export type Versions = {
     extension:       string
 }
 
-export interface GeneralChannels {
+export interface General_Channels {
     // client -> content -> devtools.html
-    Detected: DetectionState | null
+    Detected: Detection_State | null
 
-    // the `string` payload is the main version
     Debugger_Connected: {
         solid:  string | null
         client: string | null
@@ -85,7 +84,7 @@ export interface GeneralChannels {
 
 export type Channels = debug.InputChannels
               & debug.OutputChannels
-              & GeneralChannels
+              & General_Channels
 
 export type Message = utils.Union<Channels>
 
