[bug] DOM children's descendants not mapped to correct owner

[derekrjones]

1. go to: https://thetarnav.github.io/solid-devtools/
2. select DOM mode
3. find an Element node that is a child of an Element node
4. hover over it
5. incorrect owner is shown

child (correct: <Article> is owner)

child's descendant (incorrect: should be <Article> not <Main>)

solid-devtools/packages/debugger/src/structure/walker.ts

Lines 113 to 118 in 5e030e2

	elNodes[i] = MappedOwnerNode
	AddedToParentElements = true
	}
	r.push(elNode)
	elNodeData.component = MappedOwnerNode
	continue els

I believe it has something to do here, where once the first child element component property is updated, the children are skipped. I can't find anywhere else where they get updated.

[derekrjones]

I've fiddled with the following, though I'm not certain if it is correct.

// ...
elNodeData.component = MappedOwnerNode;
elNode.children.forEach(deepSetComponent); // apply to children Element nodes recursively
continue els;
// ...
function deepSetComponent(elNode: Mapped.Owner) {
  const elNodeData = elNode.type === NodeType.Element && ElementsMap.get(elNode);
  if (!elNodeData) return;
  elNodeData.component = MappedOwnerNode;
  elNode.children.forEach(deepSetComponent);
}

Also, I wonder if it would be more efficient to mapChildren before mapElements, then Elements would always get properly assigned to their Owner. This inverts the problem from a recursive search through Elements (potentially very deeply?) to one through Components, which I feel like could be pruned and made shallower (maybe even non-recursive with a lookup map). I'm still trying to figure out how the search + insertion would work.

[thetarnav]

I switched to a different algorithm now (#348). Very similar to what you've described in #339 (comment)

[derekrjones]

Cool. I'll check it out. Thanks!