✨Plumb status from ClusterExtensionRevision to ClusterExtension #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
poc-boxcutter-joe-pt2
branch
from
fdbc909 to
0f37aa8
Compare
joelanford
force-pushed
the
poc-boxcutter
branch
from
7ba6e02 to
d7f693f
Compare
joelanford
force-pushed
the
poc-boxcutter-joe-pt2
branch
2 times, most recently
from
37d9200 to
b0b7f9e
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
tmshort
reviewed
Aug 12, 2025
Comment on lines
+165
to
+168
| // TODO: jlanford's IDE says that "StateNeedsUpgrade" condition is always true, but | ||
| // it isn't immediately obvious why that is. Perhaps len(existingRevisions) is | ||
| // always greater than 0 (seems unlikely), or shouldSkipPreflight always returns | ||
| // true (and we continue) when state == StateNeedsInstall? |
There was a problem hiding this comment.
My recollection is that the preflight code does the exact same thing for both Install() and Upgrade(), so I wonder if that's it?
|
I general, looks good. Have you tried running the CI tests on it? |
thetechnick
force-pushed
the
poc-boxcutter
branch
from
2ce9e61 to
368f8f6
Compare
…on annotations Signed-off-by: Joe Lanford <[email protected]>
This change accommodates the possibility of a revision that is currently rolling out, which is possible for appliers that perform rollouts asynchronously. Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
…conciliation Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
poc-boxcutter-joe-pt2
branch
2 times, most recently
from
407007d to
ba4136f
Compare
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
poc-boxcutter-joe-pt2
branch
from
ba4136f to
7090da9
Compare
thetechnick
merged commit ae9d77c
into
thetechnick:poc-boxcutter
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat rough first iteration of status plumbing. Follow-ups will include:
Signed-off-by: Joe Lanford [email protected]
Description
Reviewer Checklist