Skip to content

Conversation

@dtfranz
Copy link

@dtfranz dtfranz commented Aug 12, 2025

Description

Defines a set of phases which facilitate a smoother installation vs applying every resource in the bundle all at once.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copy link
Owner

@thetechnick thetechnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Defines a set of phases which facilitate a smoother installation vs applying every resource in the bundle all at once.

Signed-off-by: Daniel Franz <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (poc-boxcutter@ae9d77c). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             poc-boxcutter       #4   +/-   ##
================================================
  Coverage                 ?   72.01%           
================================================
  Files                    ?       85           
  Lines                    ?     8154           
  Branches                 ?        0           
================================================
  Hits                     ?     5872           
  Misses                   ?     1890           
  Partials                 ?      392           
Flag Coverage Δ
e2e 40.05% <17.85%> (?)
experimental-e2e 44.66% <100.00%> (?)
unit 56.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thetechnick thetechnick merged commit 90c2871 into thetechnick:poc-boxcutter Aug 25, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants