test: add multirepo_test.go

Signed-off-by: Marvin Drees <[email protected]>

Author: MDr164

metadata/multirepo/multirepo.go

@@ -19,6 +19,7 @@ package multirepo
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -29,6 +30,13 @@ import (
 	"github.com/theupdateframework/go-tuf/v2/metadata/updater"
 )
 
+var (
+	// ErrNoMapFile is returned when no map file is provided
+	ErrNoMapFile = errors.New("no map file provided")
+	// ErrNoTrustedRoots is returned when no trusted root metadata is provided
+	ErrNoTrustedRoots = errors.New("no trusted root metadata provided")
+)
+
 // The following represent the map file described in TAP 4
 type Mapping struct {
 	Paths        []string `json:"paths"`
@@ -66,21 +74,21 @@ type targetMatch struct {
 func NewConfig(repoMap []byte, roots map[string][]byte) (*MultiRepoConfig, error) {
 	// error if we don't have the necessary arguments
 	if len(repoMap) == 0 || len(roots) == 0 {
-		return nil, fmt.Errorf("failed to create multi-repository config: no map file and/or trusted root metadata is provided")
+		return nil, fmt.Errorf("failed to create multi-repository config: %w and/or %w", ErrNoMapFile, ErrNoTrustedRoots)
 	}
 
 	// unmarshal the map file (note: should we expect/support unrecognized values here?)
 	var mapFile *MultiRepoMapType
 	if err := json.Unmarshal(repoMap, &mapFile); err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to unmarshal map file: %w", err)
 	}
 
 	// make sure we have enough trusted root metadata files provided based on the repository list
 	for repo := range mapFile.Repositories {
 		// check if we have a trusted root metadata for this repository
 		_, ok := roots[repo]
 		if !ok {
-			return nil, fmt.Errorf("no trusted root metadata provided for repository - %s", repo)
+			return nil, fmt.Errorf("%w for repository - %s", ErrNoTrustedRoots, repo)
 		}
 	}
 

metadata/multirepo/multirepo_test.go

@@ -0,0 +1,86 @@
+// Copyright 2024 The Update Framework Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License
+//
+// SPDX-License-Identifier: Apache-2.0
+//
+
+package multirepo
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNewConfig(t *testing.T) {
+	for _, tt := range []struct {
+		name    string
+		desc    string
+		repoMap []byte
+		roots   map[string][]byte
+		config  *MultiRepoConfig
+		wantErr error
+	}{
+		{
+			name:    "Success",
+			desc:    "This tests expects no error when creating a new config",
+			repoMap: []byte(""),
+			roots:   map[string][]byte{},
+			config:  &MultiRepoConfig{},
+			wantErr: nil,
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Logf("Desc: %s", tt.desc)
+
+			cfg, err := NewConfig(tt.repoMap, tt.roots)
+
+			if tt.wantErr == nil {
+				assert.NoErrorf(t, err, "expected no error but got %v", err)
+				return
+			}
+
+			assert.ErrorIsf(t, err, tt.wantErr, "expected error %v but got %v", tt.wantErr, err)
+			assert.Equalf(t, tt.config, cfg, "expected config %v but got %v", tt.config, cfg)
+		})
+	}
+}
+
+func TestNew(t *testing.T) {
+	for _, tt := range []struct {
+		name    string
+		desc    string
+		config  *MultiRepoConfig
+		client  *MultiRepoClient
+		wantErr error
+	}{
+		{
+			name: "",
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Logf("Desc: %s", tt.desc)
+
+			client, err := New(tt.config)
+
+			if tt.wantErr == nil {
+				assert.NoErrorf(t, err, "expected no error but got %v", err)
+				return
+			}
+
+			assert.ErrorIsf(t, err, tt.wantErr, "expected error %v but got %v", tt.wantErr, err)
+			assert.Equalf(t, tt.client, client, "expected client %v but got %v", tt.client, client)
+		})
+	}
+}