updater: Update root.json symlink on initialize

When application initializes an Updater with bootstrap, it should be
considered the trusted version from that point onwards: Update the
symlink "root.json" already here (even if refresh is never called).
n that Updater instance).

Signed-off-by: Jussi Kukkonen <[email protected]>

Author: jku

tuf/ngclient/updater.py

@@ -126,11 +126,12 @@ def __init__(
             # if no root was provided, use the cached non-versioned root.json
             bootstrap = self._load_local_metadata(Root.type)
 
-        # Load the initial root, make sure it's cached in root_history/
+        # Load the initial root, make sure it's cached
         self._trusted_set = TrustedMetadataSet(
             bootstrap, self.config.envelope_type
         )
         self._persist_root(self._trusted_set.root.version, bootstrap)
+        self._update_root_symlink()
 
     def refresh(self) -> None:
         """Refresh top-level metadata.
@@ -320,7 +321,8 @@ def _persist_metadata(self, rolename: str, data: bytes) -> None:
     def _persist_root(self, version: int, data: bytes) -> None:
         """Write root metadata to disk atomically to avoid data loss.
 
-        Use a filename prefixed with version (e.g. "1.root.json").
+        The metadata is stored with version prefix (e.g.
+        "root_history/1.root.json").
         """
         rootdir = os.path.join(self._dir, "root_history")
         with contextlib.suppress(FileExistsError):
@@ -346,6 +348,15 @@ def _persist_file(self, filename: str, data: bytes) -> None:
                     os.remove(temp_file_name)
             raise e
 
+    def _update_root_symlink(self) -> None:
+        """Symlink root.json to current trusted root version in root_history/"""
+        linkname = os.path.join(self._dir, "root.json")
+        version = self._trusted_set.root.version
+        current = os.path.join("root_history", f"{version}.root.json")
+        with contextlib.suppress(FileNotFoundError):
+            os.remove(linkname)
+        os.symlink(current, linkname)
+
     def _load_root(self) -> None:
         """Load root metadata.
 
@@ -390,12 +401,7 @@ def _load_root(self) -> None:
                     break
         finally:
             # Make sure the non-versioned root.json links to current version
-            linkname = os.path.join(self._dir, "root.json")
-            version = self._trusted_set.root.version
-            current = os.path.join("root_history", f"{version}.root.json")
-            with contextlib.suppress(FileNotFoundError):
-                os.remove(linkname)
-            os.symlink(current, linkname)
+            self._update_root_symlink()
 
     def _load_timestamp(self) -> None:
         """Load local and remote timestamp metadata."""