Refactor ci/cd workflows

Prior to this change, ci triggered cd, depending on the event that
triggered ci. Due to the vague information about that event
available to cd, the workflow pipeline was a bit brittle.

This change disassociates ci and cd workflows to allow for an
independent configuration of trigger events.

The test jobs, which used to be defined in ci, are now in a
separate workflow file _test.yml that can be included in both ci
and cd workflows.

**Changes in ci**
- Only defines trigger events and permissions, the "meat" of ci is
  defined in the called _test.yml now.
- No longer triggers on tag pushes, this was only needed for cd.

**Changes in cd**
- Now triggers directly on tag pushes instead of (cd)-workflow_run.
- Calls _test.yml, and require successful run before build/release.
  (`needs: test` replaces `if: ...`)
- Changes variable names about pushed tag that triggered the event.

Signed-off-by: Lukas Puehringer <[email protected]>

Author: Lukas Puehringer

.github/workflows/_test.yml

@@ -1,18 +1,7 @@
-name: CI
-
 on:
-  # NOTE: CD relies on this configuration (see #1961)
-  push:
-    branches:
-      - develop
-    tags:
-      - v*
-
-  pull_request:
-  workflow_dispatch:
+  workflow_call:
+  # Permissions inherited from caller workflow
 
-permissions:
-  contents: read
 
 jobs:
   tests:

.github/workflows/cd.yml

@@ -1,21 +1,20 @@
 name: CD
 concurrency: cd
 
-# Trigger workflow on any completed CI (see further checks below)
 on:
-  workflow_run:
-    workflows: [CI]
-    types: [completed]
+  push:
+    tags:
+      - v*
+
 
 jobs:
+  test:
+    uses: ./.github/workflows/_test.yml
+
   build:
     name: Build
     runs-on: ubuntu-latest
-    # Skip unless CI was successful and ran on release tag, a ref starting with 'v'.
-    # NOTE: We assume CI does not trigger on branches that start with 'v' (see #1961)
-    if: >-
-      github.event.workflow_run.conclusion == 'success' &&
-      startsWith(github.event.workflow_run.head_branch, 'v')
+    needs: test
     outputs:
       release_id: ${{ steps.gh-release.outputs.id }}
     steps:
@@ -39,8 +38,8 @@ jobs:
         name: Publish GitHub release candiate
         uses: softprops/action-gh-release@1e07f4398721186383de40550babbdf2b84acfc5
         with:
-          name: ${{ github.event.workflow_run.head_branch }}-rc
-          tag_name: ${{ github.event.workflow_run.head_branch }}
+          name: ${{ github.ref_name }}-rc
+          tag_name: ${{ github.ref }}
           body: "Release waiting for review..."
           files: dist/*
 
@@ -79,9 +78,8 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo,
               release_id: '${{ needs.build.outputs.release_id }}',
-              name: '${{ github.event.workflow_run.head_branch }}',
+              name: '${{ github.ref_name }}',
               body: 'See [CHANGELOG.md](https://github.com/' +
-                     context.repo.owner + '/' + context.repo.repo + '/blob/' +
-                     '${{ github.event.workflow_run.head_branch }}'+
-                     '/docs/CHANGELOG.md) for details.'
+                     context.repo.owner + '/' + context.repo.repo +
+                    '/blob/${{ github.ref_name }}/docs/CHANGELOG.md) for details.'
             })

.github/workflows/ci.yml

@@ -0,0 +1,16 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - develop
+
+  pull_request:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    uses: ./.github/workflows/_test.yml