Skip to content

Commit e7544bf

Browse files
author
Lukas Puehringer
committed
build: fix success message in verify_release
Prior to #1946 the verify_release script was successful if both PyPI and GitHub release artifacts matched the local build. Now, if the `--skip-pypi` option is provided, the script can also be successful if only the GitHub release artifacts match the local build. This commit splits the final success message in two separate success messages, one for PyPI and one for GitHub. Signed-off-by: Lukas Puehringer <[email protected]>
1 parent a50062f commit e7544bf

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

verify_release

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,16 @@ def main() -> int:
172172
# This is expected while build is not reproducible
173173
finished("ERROR: PyPI artifacts do not match built release")
174174
success = False
175+
else:
176+
finished(f"PyPI artifacts match the built release")
175177

176178
progress("Downloading release from GitHub")
177179
if not verify_github_release(build_version, build_dir):
178180
# This is expected while build is not reproducible
179181
finished("ERROR: GitHub artifacts do not match built release")
180182
success = False
181-
182-
if success:
183-
finished("Github and PyPI artifacts match the built release")
183+
else:
184+
finished(f"GitHub artifacts match the built release")
184185

185186
return 0 if success else 1
186187

0 commit comments

Comments
 (0)