Skip to content

Conversation

@jku
Copy link
Member

@jku jku commented Mar 5, 2025

I suppose this is ready.
Fixes #2796

@jku jku requested a review from a team as a code owner March 5, 2025 14:39
@jku jku marked this pull request as draft March 5, 2025 14:39
@kairoaraujo kairoaraujo self-requested a review March 5, 2025 17:00
@jku jku marked this pull request as ready for review March 7, 2025 12:08
@jku
Copy link
Member Author

jku commented Mar 7, 2025

Tested with sigstore-python, found one minor usability issue: #2807. I think we should include the fix (#2808) in the release. No need to change the Changelog IMO.

EDIT: #2808 has been merged

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I only skimmed through the related PRs but everything looks well tested and has been reviewed, so I'm happy to approve after the conflict is resolved.

* ngclient: TLS certificate source was changed. Certificates now come from operating
system certificate store instead of `certifi` (#2762)
* ngclient: The updater can now initialize from embedded initial root metadata every
time. Users are recommended to provide the `bootstrap` argument to Updater.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
time. Users are recommended to provide the `bootstrap` argument to Updater.
time. Users are recommended to provide the `bootstrap` argument to Updater. (#2767)

Signed-off-by: Jussi Kukkonen <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 97.076%. remained the same
when pulling 0c449a9 on jku:prep-v6
into bef804b on theupdateframework:develop.

@coveralls
Copy link

Coverage Status

coverage: 97.076%. remained the same
when pulling 44eed61 on jku:prep-v6
into bef804b on theupdateframework:develop.

@jku jku merged commit bb6d459 into theupdateframework:develop Mar 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new release

3 participants