Skip to content

Commit 1256715

Browse files
committed
Revert "Remove 2nd targets rollback attack check"
This reverts commit 2eccb59. 2eccb59 removed rollback attack check for top-level targets file, which is (1) redundant and (2) prevents recovery from a fast-forward attack (see commit message for details). This commit reverts the change, because the redundancy (1) is actually desired, so that an attacker does not only have to compromise timestamp, but snapshot and (delegated) targets too, in order to launch rollback attacks. Fast-forward attack recovery (2) shall be fixed in a subsequent comment.
1 parent 0f56aee commit 1256715

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

tuf-spec.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,36 +1222,42 @@ non-volatile storage as FILENAME.EXT.
12221222
trusted root metadata file. If the new targets metadata file is not signed
12231223
as required, discard it, abort the update cycle, and report the failure.
12241224

1225-
* **4.3**. **Check for a freeze attack.** The latest known time should be
1225+
* **4.3**. **Check for a rollback attack.** The version number of the trusted
1226+
targets metadata file, if any, MUST be less than or equal to the version
1227+
number of the new targets metadata file. If the new targets metadata file is
1228+
older than the trusted targets metadata file, discard it, abort the update
1229+
cycle, and report the potential rollback attack.
1230+
1231+
* **4.4**. **Check for a freeze attack.** The latest known time should be
12261232
lower than the expiration timestamp in the new targets metadata file. If so,
12271233
the new targets metadata file becomes the trusted targets metadata file. If
12281234
the new targets metadata file is expired, discard it, abort the update cycle,
12291235
and report the potential freeze attack.
12301236

1231-
* **4.4**. **Perform a preorder depth-first search for metadata about the
1237+
* **4.5**. **Perform a preorder depth-first search for metadata about the
12321238
desired target, beginning with the top-level targets role.** Note: If
1233-
any metadata requested in steps 4.4.1 - 4.4.2.3 cannot be downloaded nor
1239+
any metadata requested in steps 4.5.1 - 4.5.2.3 cannot be downloaded nor
12341240
validated, end the search and report that the target cannot be found.
12351241

1236-
* **4.4.1**. If this role has been visited before, then skip this role (so
1242+
* **4.5.1**. If this role has been visited before, then skip this role (so
12371243
that cycles in the delegation graph are avoided). Otherwise, if an
12381244
application-specific maximum number of roles have been visited, then go to
12391245
step 5 (so that attackers cannot cause the client to waste excessive
12401246
bandwidth or time). Otherwise, if this role contains metadata about the
12411247
desired target, then go to step 5.
12421248

1243-
* **4.4.2**. Otherwise, recursively search the list of delegations in order
1249+
* **4.5.2**. Otherwise, recursively search the list of delegations in order
12441250
of appearance.
12451251

1246-
* **4.4.2.1**. If the current delegation is a multi-role delegation,
1252+
* **4.5.2.1**. If the current delegation is a multi-role delegation,
12471253
recursively visit each role, and check that each has signed exactly the
12481254
same non-custom metadata (i.e., length and hashes) about the target (or
12491255
the lack of any such metadata).
12501256

1251-
* **4.4.2.2**. If the current delegation is a terminating delegation,
1257+
* **4.5.2.2**. If the current delegation is a terminating delegation,
12521258
then jump to step 5.
12531259

1254-
* **4.4.2.3**. Otherwise, if the current delegation is a non-terminating
1260+
* **4.5.2.3**. Otherwise, if the current delegation is a non-terminating
12551261
delegation, continue processing the next delegation, if any. Stop the
12561262
search, and jump to step 5 as soon as a delegation returns a result.
12571263

0 commit comments

Comments
 (0)