Skip to content

Commit ebd2f42

Browse files
committed
Revert "Remove 2nd targets rollback attack check"
This reverts commit 2eccb59. 2eccb59 removed rollback attack check for top-level targets file, which is (1) redundant and (2) prevents recovery from a fast-forward attack (see commit message for details). This commit reverts the change, because the redundancy (1) is actually desired, so that an attacker does not only have to compromise timestamp, but snapshot and (delegated) targets too, in order to launch rollback attacks. Fast-forward attack recovery (2) shall be fixed in a subsequent comment.
1 parent 4db06fc commit ebd2f42

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

tuf-spec.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1218,36 +1218,42 @@ non-volatile storage as FILENAME.EXT.
12181218
trusted root metadata file. If the new targets metadata file is not signed
12191219
as required, discard it, abort the update cycle, and report the failure.
12201220

1221-
* **4.3**. **Check for a freeze attack.** The latest known time should be
1221+
* **4.3**. **Check for a rollback attack.** The version number of the trusted
1222+
targets metadata file, if any, MUST be less than or equal to the version
1223+
number of the new targets metadata file. If the new targets metadata file is
1224+
older than the trusted targets metadata file, discard it, abort the update
1225+
cycle, and report the potential rollback attack.
1226+
1227+
* **4.4**. **Check for a freeze attack.** The latest known time should be
12221228
lower than the expiration timestamp in the new targets metadata file. If so,
12231229
the new targets metadata file becomes the trusted targets metadata file. If
12241230
the new targets metadata file is expired, discard it, abort the update cycle,
12251231
and report the potential freeze attack.
12261232

1227-
* **4.4**. **Perform a preorder depth-first search for metadata about the
1233+
* **4.5**. **Perform a preorder depth-first search for metadata about the
12281234
desired target, beginning with the top-level targets role.** Note: If
1229-
any metadata requested in steps 4.4.1 - 4.4.2.3 cannot be downloaded nor
1235+
any metadata requested in steps 4.5.1 - 4.5.2.3 cannot be downloaded nor
12301236
validated, end the search and report that the target cannot be found.
12311237

1232-
* **4.4.1**. If this role has been visited before, then skip this role (so
1238+
* **4.5.1**. If this role has been visited before, then skip this role (so
12331239
that cycles in the delegation graph are avoided). Otherwise, if an
12341240
application-specific maximum number of roles have been visited, then go to
12351241
step 5 (so that attackers cannot cause the client to waste excessive
12361242
bandwidth or time). Otherwise, if this role contains metadata about the
12371243
desired target, then go to step 5.
12381244

1239-
* **4.4.2**. Otherwise, recursively search the list of delegations in order
1245+
* **4.5.2**. Otherwise, recursively search the list of delegations in order
12401246
of appearance.
12411247

1242-
* **4.4.2.1**. If the current delegation is a multi-role delegation,
1248+
* **4.5.2.1**. If the current delegation is a multi-role delegation,
12431249
recursively visit each role, and check that each has signed exactly the
12441250
same non-custom metadata (i.e., length and hashes) about the target (or
12451251
the lack of any such metadata).
12461252

1247-
* **4.4.2.2**. If the current delegation is a terminating delegation,
1253+
* **4.5.2.2**. If the current delegation is a terminating delegation,
12481254
then jump to step 5.
12491255

1250-
* **4.4.2.3**. Otherwise, if the current delegation is a non-terminating
1256+
* **4.5.2.3**. Otherwise, if the current delegation is a non-terminating
12511257
delegation, continue processing the next delegation, if any. Stop the
12521258
search, and jump to step 5 as soon as a delegation returns a result.
12531259

0 commit comments

Comments
 (0)