Scramble Matching With multiple groups in FMC produces unexpected Results

[Jambrose777]

When using the scramble matcher on FMC, if the Delegate has multiple groups of scrambles; instead of producing results with multiple groups of scrambles, the result json will have 1 group with double the scrambles.

Example:
TestingFMC.zip
I generated a Results JSON with 1 round of FMC 3 attempts (TestingFMC (1).xlsx)
I also generated Scrambles for 1 round of FMC 2 groups (Testing FMC.json)
I entered them in the scramble matcher and automatically assigned scrambles. Here is a screenshot of that:

The results json is also included in the zip. (Results for testingFMC.json)

On the one hand there should pretty much never be multiple scramble sets used for FMC. But on the other, this behavior of the Scramble matcher will cause errors if that were to ever happen.

If this is fixed on the scramble matcher, I think it would also be nice to include a warning in the Result Submission process so WRT can investigate when the Delegate uploads results. Issue for that: thewca/worldcubeassociation.org#5725

[Jambrose777]

FYI: There are 22 scrambles that are of a different group in FMC. WRT will investigate these cases.

[jonatanklosko]

@viroulep I've just had a quick look and this seems to be the code responsible for that:

scrambles-matcher/src/logic/scrambles.js

Lines 180 to 197 in f7da683

	} else if (eventId === '333fm') {
	// We can't track yet in the WCIF which scramble was for witch attempt,
	// so let's just sort them by attempt id and combine them in one
	// scramble sheet.
	// There is usually only one group for FM, the only case where we would
	// like more scramble than expected is when something terrible happened
	// and an extra was needed.
	return [
	{
	id: scrambles[0].id,
	scrambles: flatMap(
	sortBy(scrambles, s => s.attemptNumber),
	s => s.scrambles
	),
	extraScrambles: [],
	},
	];
	}

As far as I can tell the FMC scrambles are internally split into one set per attempt, so given 2 groups of 3 attempts there are 6 internal scramble sets. The above code then merges them all into one scramble set, as if there was just one group. Any reason for handling this differently than MBLD, which handles multiple groups? (directly above the referenced code)

[jonatanklosko]

I believe this has been fixed in #15. Correct me if I'm wrong =)

[Jambrose777]

I don't believe it did. That PR fixed the issue with not being able to have multiple groups of any events due to the UI bugging out. This has to do with how FMC scrambles are generated after they have been properly selected in the UI.

[jonatanklosko]

Ah, gotcha!