fix: validate cursor after refresh to prevent panic

Author: thewizardshell

internal/tui/update/update.go

@@ -579,7 +579,7 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 		if m.CurrentView == model.FileView {
 			switch msg.String() {
 			case " ":
-				if len(m.Files) > 0 {
+				if len(m.Files) > 0 && m.Cursor < len(m.Files) {
 					f := &m.Files[m.Cursor]
 					f.Staged = !f.Staged
 					if f.Staged {
@@ -590,16 +590,29 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 						m.Message = fmt.Sprintf("✓ File %s removed from stage", f.Name)
 					}
 					m.MessageType = "success"
+				} else {
+					// Resetear cursor y mostrar mensaje apropiado
+					if len(m.Files) > 0 {
+						m.Cursor = 0
+					} else {
+						m.Message = "⚠ No files to stage"
+						m.MessageType = "warning"
+					}
 				}
 			case "a":
-				for i := range m.Files {
-					if !m.Files[i].Staged {
-						m.Files[i].Staged = true
-						git.Add(m.Files[i].Name)
+				if len(m.Files) > 0 {
+					for i := range m.Files {
+						if !m.Files[i].Staged {
+							m.Files[i].Staged = true
+							git.Add(m.Files[i].Name)
+						}
 					}
+					m.Message = "✓ All files added to stage"
+					m.MessageType = "success"
+				} else {
+					m.Message = "⚠ No files to stage"
+					m.MessageType = "warning"
 				}
-				m.Message = "✓ All files added to stage"
-				m.MessageType = "success"
 			case "c":
 				ok := false
 				for _, f := range m.Files {
@@ -625,6 +638,7 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 				m.Message = ""
 			case "r":
 				m.RefreshData()
+				utils.ValidateCursor(&m)
 				m.Message = "✓ Status updated"
 				m.MessageType = "success"
 			case "p":
@@ -657,10 +671,13 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 				m.MessageType = "info"
 				return m, nil
 			case "x":
-				if len(m.Files) > 0 {
+				if len(m.Files) > 0 && m.Cursor < len(m.Files) {
 					m.DialogType = "discard_changes"
 					m.DialogTarget = m.Files[m.Cursor].Name
 					m.CurrentView = model.ConfirmDialog
+				} else {
+					m.Message = "⚠ No file selected or no files available"
+					m.MessageType = "warning"
 				}
 			case "?":
 				if m.CurrentView == model.FileView {
@@ -691,6 +708,7 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 			m.DialogTarget = ""
 			m.LogLines = nil
 			m.RefreshData()
+			utils.ValidateCursor(&m)
 		}
 
 	case fetchMsg:
@@ -702,6 +720,7 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 			m.Message = "✓ Changes fetched successfully"
 			m.MessageType = "success"
 			m.RefreshData()
+			utils.ValidateCursor(&m)
 		}
 
 	case pullMsg:
@@ -713,6 +732,7 @@ func Update(m model.Model, msg tea.Msg) (model.Model, tea.Cmd) {
 			m.Message = "✓ Changes pulled successfully"
 			m.MessageType = "success"
 			m.RefreshData()
+			utils.ValidateCursor(&m)
 		}
 	}
 

internal/utils/validate_cursor.go

@@ -0,0 +1,33 @@
+// validateCursor ensures the cursor is within valid bounds for the current view
+package utils
+
+import "froggit/internal/tui/model"
+
+func ValidateCursor(m *model.Model) {
+	switch m.CurrentView {
+	case model.FileView:
+		if len(m.Files) == 0 {
+			m.Cursor = 0
+		} else if m.Cursor >= len(m.Files) {
+			m.Cursor = len(m.Files) - 1
+		} else if m.Cursor < 0 {
+			m.Cursor = 0
+		}
+	case model.BranchView:
+		if len(m.Branches) == 0 {
+			m.Cursor = 0
+		} else if m.Cursor >= len(m.Branches) {
+			m.Cursor = len(m.Branches) - 1
+		} else if m.Cursor < 0 {
+			m.Cursor = 0
+		}
+	case model.RemoteView:
+		if len(m.Remotes) == 0 {
+			m.Cursor = 0
+		} else if m.Cursor >= len(m.Remotes) {
+			m.Cursor = len(m.Remotes) - 1
+		} else if m.Cursor < 0 {
+			m.Cursor = 0
+		}
+	}
+}