fix lint issues

Author: C8Y-Mario

justfile

@@ -60,4 +60,4 @@ cleanup DEVICE_ID $CI="true":
     echo "Removing device and child devices (including certificates)"
     c8y devicemanagement certificates list -n --tenant "$(c8y currenttenant get --select name --output csv)" --filter "name eq ${DEVICE_ID}" --pageSize 2000 | c8y devicemanagement certificates delete --tenant "$(c8y currenttenant get --select name --output csv)"
     c8y inventory find -n --owner "device_${DEVICE_ID}" -p 100 | c8y inventory delete
-    c8y users delete -n --id "device_${DEVICE_ID}$" --tenant "$(c8y currenttenant get --select name --output csv)" --silentStatusCodes 404 --silentExit
+    c8y users delete -n --id "device_${DEVICE_ID}$" --tenant "$(c8y currenttenant get --select name --output csv)" --silentStatusCodes 404 --silentExit

tedge_modbus/operations/c8y_modbus_configuration.py

@@ -34,10 +34,9 @@ def run(arguments, context: Context):
     modbus_config["modbus"]["pollinterval"] = polling_rate
 
     # Save to file
-    logger.info("Saving new configuration to %s", config_path)
-    with open(config_path, "w", encoding="utf8") as f:
+    logger.info("Saving new configuration to %s", context.base_config_path)
+    with open(context.base_config_path, "w", encoding="utf8") as f:
         toml.dump(modbus_config, f)
-    logger.info("New configuration saved to %s", config_path)
 
     # Update managedObject
     logger.debug("Updating managedObject with new configuration")

tedge_modbus/operations/c8y_modbus_device.py

@@ -86,9 +86,9 @@ def parse_arguments(arguments) -> ModebusDevice:
 
 
 def run(arguments, context: Context):
+    """main"""
     loglevel = context.base_config["modbus"]["loglevel"] or "INFO"
     logger.setLevel(getattr(logging, loglevel.upper(), logging.INFO))
-    """main"""
     logger.info("New c8y_ModbusDevice operation")
     # Check and store arguments
     if len(arguments) != 8:

tedge_modbus/operations/context.py

@@ -3,7 +3,7 @@
 import subprocess
 from dataclasses import dataclass
 from pathlib import Path
-
+import toml
 
 @dataclass
 class Context:
@@ -14,6 +14,7 @@ class Context:
     port = 1883
     client_id = "c8y_ModbusConfiguration-operation-client"
     config_dir = Path("/etc/tedge/plugins/modbus")
+    base_config_path = config_dir / "modbus.toml"
 
     @property
     def c8y_proxy(self) -> str:
@@ -37,5 +38,5 @@ def device_id(self):
 
     @property
     def base_config(self):
-        config_path = config_dir / "modbus.toml"
-        return toml.load(config_path)
+        """loads the default modbus.toml file and gives it back as dict"""
+        return toml.load(self.base_config_path)