fixup! JS TextEncoder: encodeInto method

Author: didier-wenzek

crates/extensions/tedge_flows/src/js_lib/text_encoder.rs

@@ -6,7 +6,6 @@ use rquickjs::JsLifetime;
 use rquickjs::Object;
 use rquickjs::Result;
 use rquickjs::TypedArray;
-use rquickjs::Value;
 
 #[derive(Clone, Trace, JsLifetime)]
 #[rquickjs::class(frozen)]
@@ -29,19 +28,23 @@ impl<'js> TextEncoder {
         "utf-8"
     }
 
-    pub fn encode(&self, ctx: Ctx<'js>, text: Value<'js>) -> Result<TypedArray<'js, u8>> {
-        let string = Self::string_from(text)?;
+    pub fn encode(
+        &self,
+        ctx: Ctx<'js>,
+        text: rquickjs::String<'js>,
+    ) -> Result<TypedArray<'js, u8>> {
+        let string = text.to_string()?;
         TypedArray::new(ctx.clone(), string.as_bytes())
     }
 
     #[qjs(rename = "encodeInto")]
     pub fn encode_into(
         &self,
         ctx: Ctx<'js>,
-        text: Value<'js>,
+        text: rquickjs::String<'js>,
         array: TypedArray<'js, u8>,
     ) -> Result<Object<'js>> {
-        let string = Self::string_from(text)?;
+        let string = text.to_string()?;
         let offset: usize = array.get("byteOffset").unwrap_or_default();
         let buffer = array
             .arraybuffer()?
@@ -73,19 +76,3 @@ impl<'js> TextEncoder {
         Ok(obj)
     }
 }
-
-impl TextEncoder {
-    pub fn string_from(text: Value<'_>) -> Result<String> {
-        let string = match text.as_string() {
-            None => text
-                .as_object()
-                .and_then(|object| object.as_typed_array::<u8>())
-                .and_then(|array| array.as_bytes())
-                .and_then(|bytes| std::str::from_utf8(bytes).ok())
-                .map(|s| s.to_string())
-                .unwrap_or_default(),
-            Some(js_string) => js_string.to_string()?,
-        };
-        Ok(string)
-    }
-}