Use OperationType::name instead of OperationType::to_string()

In order to better convey the intent.

Signed-off-by: Didier Wenzek <[email protected]>

Author: didier-wenzek

crates/core/tedge_agent/src/operation_workflows/persist.rs

@@ -402,7 +402,7 @@ impl WorkflowRepository {
         operation: &OperationType,
         command_state: GenericCommandState,
     ) -> Result<Option<GenericCommandState>, WorkflowExecutionError> {
-        let operation_name = operation.to_string();
+        let operation_name = operation.name();
         if command_state.is_init() {
             // A new command instance must use the latest on-disk version of the operation workflow
             self.load_latest_version(&operation_name).await;

crates/core/tedge_api/src/mqtt_topics.rs

@@ -737,12 +737,6 @@ impl<'a> From<&'a str> for OperationType {
     }
 }
 
-impl From<&OperationType> for String {
-    fn from(value: &OperationType) -> Self {
-        format!("{value}")
-    }
-}
-
 impl Display for OperationType {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
@@ -760,6 +754,12 @@ impl Display for OperationType {
     }
 }
 
+impl OperationType {
+    pub fn name(&self) -> String {
+        format!("{self}")
+    }
+}
+
 #[derive(Debug, thiserror::Error, PartialEq, Eq, Clone)]
 pub enum ChannelError {
     #[error("Channel needs to have at least 2 segments")]

crates/core/tedge_api/src/workflow/mod.rs

@@ -342,7 +342,7 @@ impl OperationWorkflow {
         self.states
             .get(&command_state.status)
             .ok_or_else(|| WorkflowExecutionError::UnknownStep {
-                operation: (&self.operation).into(),
+                operation: self.operation.name(),
                 step: command_state.status.clone(),
             })
             .map(|action| action.inject_state(command_state))