add precommit and start fixing types

Author: cjber

.github/workflows/pr-check.yml

@@ -0,0 +1,84 @@
+name: Linting and Type Checking
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: "3.10"
+  UV_PROJECT_ENVIRONMENT: .venv
+  
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  check-ai:
+    name: Check thirdweb-ai
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: ./python/thirdweb-ai
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@22695119d769bdb6f7032ad67b9bca0ef8c4a174 # v5
+
+      - name: Install Python
+        uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+        with:
+          enable-cache: true
+          cache-dependency-glob: "uv.lock"
+
+      - name: Install the project
+        run: uv sync --all-extras --dev
+
+      - name: Configure path
+        run: echo "$PWD/.venv/bin" >> $GITHUB_PATH
+
+      - name: Run Ruff linter
+        run: uv run ruff check --output-format=github .
+
+      - name: Run Ruff formatter
+        run: uv run ruff format --check .
+
+      - name: Run Pyright check
+        uses: jakebailey/pyright-action@b5d50e5cde6547546a5c4ac92e416a8c2c1a1dfe # v2.3.2
+        with:
+          version: PATH
+          working-directory: ./python/thirdweb-ai
+          
+  check-mcp:
+    name: Check thirdweb-mcp
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: ./python/thirdweb-mcp
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@22695119d769bdb6f7032ad67b9bca0ef8c4a174 # v5
+
+      - name: Install Python
+        uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+        with:
+          enable-cache: true
+          cache-dependency-glob: "uv.lock"
+
+      - name: Install the project
+        run: uv sync --all-extras --dev
+
+      - name: Configure path
+        run: echo "$PWD/.venv/bin" >> $GITHUB_PATH
+
+      - name: Run Ruff linter
+        run: uv run ruff check --output-format=github .
+
+      - name: Run Ruff formatter
+        run: uv run ruff format --check .
+
+      - name: Run Pyright check
+        uses: jakebailey/pyright-action@b5d50e5cde6547546a5c4ac92e416a8c2c1a1dfe # v2.3.2
+        with:
+          version: PATH
+          working-directory: ./python/thirdweb-mcp

.pre-commit-config.yaml

@@ -0,0 +1,46 @@
+repos:
+  - repo: local
+    hooks:
+      # thirdweb-ai linting
+      - id: ruff-check-ai
+        name: ruff check (thirdweb-ai)
+        entry: bash -c 'cd python/thirdweb-ai && uv run ruff check --fix .'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-ai/
+      - id: ruff-format-ai
+        name: ruff format (thirdweb-ai)
+        entry: bash -c 'cd python/thirdweb-ai && uv run ruff format .'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-ai/
+        
+      # thirdweb-mcp linting
+      - id: ruff-check-mcp
+        name: ruff check (thirdweb-mcp)
+        entry: bash -c 'cd python/thirdweb-mcp && uv run ruff check --fix .'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-mcp/
+      - id: ruff-format-mcp
+        name: ruff format (thirdweb-mcp)
+        entry: bash -c 'cd python/thirdweb-mcp && uv run ruff format .'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-mcp/
+        
+      # thirdweb-ai type checking
+      - id: pyright-ai
+        name: pyright (thirdweb-ai)
+        entry: bash -c 'cd python/thirdweb-ai && uv run pyright'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-ai/
+        
+      # thirdweb-mcp type checking
+      - id: pyright-mcp
+        name: pyright (thirdweb-mcp)
+        entry: bash -c 'cd python/thirdweb-mcp && uv run pyright'
+        language: system
+        pass_filenames: false
+        files: ^python/thirdweb-mcp/

python/examples/adapter_google_adk/example.py

@@ -43,8 +43,7 @@ async def setup_agent() -> Runner:
     agent = LlmAgent(
         model=LiteLlm(model="gpt-4o-mini"),
         name="thirdweb_insight_agent",
-        # Convert BaseTool to the expected type for LlmAgent
-        tools=adk_tools,  # type: ignore
+        tools=adk_tools,
     )
 
     # Set up session
@@ -68,9 +67,7 @@ async def call_agent(query: str) -> None:
 
     for event in events:
         if (
-            hasattr(event, "is_final_response")
-            and event.is_final_response()
-            and (event.content and hasattr(event.content, "parts") and event.content.parts)
+            event.is_final_response()
         ):
             final_response = event.content.parts[0].text
             print("Agent Response: ", final_response)

python/examples/adapter_google_adk/pyproject.toml

@@ -5,7 +5,7 @@ description = "Example of using thirdweb_ai with Google ADK"
 authors = [{ name = "thirdweb", email = "[email protected]" }]
 requires-python = "~=3.10"
 dependencies = [
-    "thirdweb-ai[google-adk]"
+    "thirdweb-ai[google-adk]>=0.1.17"
 ]
 
 [tool.uv]