Add filters to GetAll fns and tests

Author: 0xFirekeeper

Thirdweb.Tests/Thirdweb.Extensions/Thirdweb.Extensions.Tests.cs

@@ -893,6 +893,17 @@ public async Task GetNFT_721()
         Assert.True(nft.QuantityOwned == 1);
     }
 
+    [Fact(Timeout = 120000)]
+    public async Task GetNFT_721_NoOwner()
+    {
+        var contract = await this.GetTokenERC721Contract();
+        var nft = await contract.ERC721_GetNFT(0, false);
+        Assert.Equal(Constants.ADDRESS_ZERO, nft.Owner);
+        Assert.Equal(NFTType.ERC721, nft.Type);
+        Assert.True(nft.Supply == 1);
+        Assert.True(nft.QuantityOwned == 1);
+    }
+
     [Fact(Timeout = 120000)]
     public async Task GetAllNFTs_721()
     {
@@ -902,6 +913,16 @@ public async Task GetAllNFTs_721()
         Assert.NotEmpty(nfts);
     }
 
+    [Fact(Timeout = 120000)]
+    public async Task GetAllNFTs_721_NoOwner()
+    {
+        var contract = await this.GetTokenERC721Contract();
+        var nfts = await contract.ERC721_GetAllNFTs(fillOwner: false);
+        Assert.NotNull(nfts);
+        Assert.NotEmpty(nfts);
+        Assert.True(nfts.All(nft => nft.Owner == Constants.ADDRESS_ZERO));
+    }
+
     [Fact(Timeout = 120000)]
     public async Task GetAllNFTs_721_ExceedTotalSupply()
     {
@@ -984,6 +1005,15 @@ public async Task GetNFT_1155()
         Assert.True(nft.Supply >= 0);
     }
 
+    [Fact(Timeout = 120000)]
+    public async Task GetNFT_1155_NoSupply()
+    {
+        var contract = await this.GetTokenERC1155Contract();
+        var nft = await contract.ERC1155_GetNFT(0, false);
+        Assert.Equal(NFTType.ERC1155, nft.Type);
+        Assert.True(nft.Supply == -1);
+    }
+
     [Fact(Timeout = 120000)]
     public async Task GetAllNFTs_1155()
     {
@@ -993,6 +1023,16 @@ public async Task GetAllNFTs_1155()
         Assert.NotEmpty(nfts);
     }
 
+    [Fact(Timeout = 120000)]
+    public async Task GetAllNFTs_1155_NoSupply()
+    {
+        var contract = await this.GetTokenERC1155Contract();
+        var nfts = await contract.ERC1155_GetAllNFTs(fillSupply: false);
+        Assert.NotNull(nfts);
+        Assert.NotEmpty(nfts);
+        Assert.True(nfts.All(nft => nft.Supply == -1));
+    }
+
     [Fact(Timeout = 120000)]
     public async Task GetAllNFTs_1155_ExceedTotalSupply()
     {

Thirdweb/Thirdweb.Extensions/ThirdwebExtensions.cs

@@ -1228,9 +1228,10 @@ public static async Task<NFT> ERC721_GetNFT(this ThirdwebContract contract, BigI
     /// <param name="contract">The contract to interact with.</param>
     /// <param name="startTokenId">The starting token ID (inclusive). Defaults to 0 if not specified.</param>
     /// <param name="count">The number of tokens to retrieve. Defaults to 100 if not specified.</param>
+    /// <param name="fillOwner">A boolean indicating whether to fill the owner details. Defaults to true.</param>
     /// <returns>A task representing the asynchronous operation, with a list of NFT results containing the token details.</returns>
     /// <exception cref="ArgumentNullException">Thrown when the contract is null.</exception>
-    public static async Task<List<NFT>> ERC721_GetAllNFTs(this ThirdwebContract contract, int startTokenId = 0, int count = 100)
+    public static async Task<List<NFT>> ERC721_GetAllNFTs(this ThirdwebContract contract, int startTokenId = 0, int count = 100, bool fillOwner = true)
     {
         if (contract == null)
         {
@@ -1243,7 +1244,7 @@ public static async Task<List<NFT>> ERC721_GetAllNFTs(this ThirdwebContract cont
         var nftTasks = new List<Task<NFT>>();
         for (var i = startTokenId; i < startTokenId + count; i++)
         {
-            nftTasks.Add(contract.ERC721_GetNFT(i));
+            nftTasks.Add(contract.ERC721_GetNFT(i, fillOwner));
         }
 
         var allNfts = await Task.WhenAll(nftTasks).ConfigureAwait(false);
@@ -1377,31 +1378,32 @@ public static async Task<NFT> ERC1155_GetNFT(this ThirdwebContract contract, Big
     /// <param name="contract">The contract to interact with.</param>
     /// <param name="startTokenId">The starting token ID (inclusive). Defaults to 0 if not specified.</param>
     /// <param name="count">The number of tokens to retrieve. Defaults to the 100 if not specified.</param>
+    /// <param name="fillSupply">A boolean indicating whether to fill the supply. Defaults to true if not specified.</param>
     /// <returns>A task representing the asynchronous operation, with a list of NFT results containing the token details.</returns>
     /// <exception cref="ArgumentNullException">Thrown when the contract is null.</exception>
-    public static async Task<List<NFT>> ERC1155_GetAllNFTs(this ThirdwebContract contract, int startTokenId = 0, int count = 100)
+    public static async Task<List<NFT>> ERC1155_GetAllNFTs(this ThirdwebContract contract, int startTokenId = 0, int count = 100, bool fillSupply = true)
     {
         if (contract == null)
         {
             throw new ArgumentNullException(nameof(contract));
         }
 
-        BigInteger totalSupply;
+        BigInteger totalCount;
         try
         {
             // Not part of IERC1155 so we fallback just in case
-            totalSupply = await contract.ERC1155_TotalSupply().ConfigureAwait(false);
+            totalCount = await contract.ERC1155_TotalSupply().ConfigureAwait(false);
         }
         catch
         {
-            totalSupply = int.MaxValue;
+            totalCount = int.MaxValue;
         }
-        count = Math.Min(count, (int)(totalSupply - startTokenId));
+        count = Math.Min(count, (int)(totalCount - startTokenId));
 
         var nftTasks = new List<Task<NFT>>();
         for (var i = startTokenId; i < startTokenId + count; i++)
         {
-            nftTasks.Add(contract.ERC1155_GetNFT(i));
+            nftTasks.Add(contract.ERC1155_GetNFT(i, fillSupply));
         }
 
         var allNfts = await Task.WhenAll(nftTasks).ConfigureAwait(false);