don't serialize if already string

0xFirekeeper · 0xFirekeeper · commit ddc1133a4d76 · 2025-03-01T03:41:19.000+07:00
diff --git a/Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs b/Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs
@@ -203,7 +203,7 @@ private async Task SendBatchAsync(List<RpcRequest> batch)
                                 }
                                 catch
                                 {
-                                    revertMsg = JsonConvert.SerializeObject(rpcResponse.Error.Data);
+                                    revertMsg = rpcResponse.Error.Data is string ? rpcResponse.Error.Data.ToString() : JsonConvert.SerializeObject(rpcResponse.Error.Data);
                                 }
                             }
                             tcs.SetException(new Exception($"RPC Error for request {rpcResponse.Id}: {rpcResponse.Error.Message} {revertMsg}"));

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ private async Task SendBatchAsync(List<RpcRequest> batch)`
`203`	`203`	`}`
`204`	`204`	`catch`
`205`	`205`	`{`
`206`		`- revertMsg = JsonConvert.SerializeObject(rpcResponse.Error.Data);`
	`206`	`+ revertMsg = rpcResponse.Error.Data is string ? rpcResponse.Error.Data.ToString() : JsonConvert.SerializeObject(rpcResponse.Error.Data);`
`207`	`207`	`}`
`208`	`208`	`}`
`209`	`209`	`tcs.SetException(new Exception($"RPC Error for request {rpcResponse.Id}: {rpcResponse.Error.Message} {revertMsg}"));`