Skip to content

Marketplace Extensions #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 9, 2024
Merged

Marketplace Extensions #85

merged 10 commits into from
Oct 9, 2024

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 4, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the Thirdweb marketplace functionality by adding support for interface checks, creating and managing listings and auctions, and implementing offer handling. It also includes new constants and test cases for these features.

Detailed summary

  • Added SupportsInterface method to ThirdwebContract.
  • Introduced new constants for ERC20, ERC721, and ERC1155 interface IDs.
  • Implemented ListingParameters and Listing classes for direct listings.
  • Developed AuctionParameters and Auction classes for auctions.
  • Created OfferParams and Offer classes for offers.
  • Added methods for creating, updating, canceling listings and auctions in ThirdwebMarketplaceExtensions.
  • Implemented tests for marketplace functionalities, including listings, auctions, and offers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.95595% with 318 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (179904c) to head (1273eeb).

Files with missing lines Patch % Lines
...irdweb.Extensions/ThirdwebMarketplaceExtensions.cs 22.16% 276 Missing and 26 partials ⚠️
....Extensions/ThirdwebMarketplaceExtensions.Types.cs 73.33% 16 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   84.12%   78.53%   -5.60%     
==========================================
  Files          26       28       +2     
  Lines        3873     4327     +454     
  Branches      531      603      +72     
==========================================
+ Hits         3258     3398     +140     
- Misses        480      769     +289     
- Partials      135      160      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 9af3fa0 into main Oct 9, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/marketplace-extensions branch October 9, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xFirekeeper @codecov-commenter