address review feedback

Author: d4mr

core/src/execution_options/mod.rs

@@ -46,7 +46,7 @@ where
     if !map.contains_key("type") {
         map.insert(
             "type".to_string(),
-            serde_json::Value::String("Auto".to_string()),
+            serde_json::Value::String("auto".to_string()),
         );
     }
 

core/src/signer.rs

@@ -1,5 +1,3 @@
-use std::option;
-
 use alloy::{
     dyn_abi::TypedData,
     primitives::{Address, ChainId},

core/src/userop.rs

@@ -43,7 +43,7 @@ impl UserOpVersion {
                     pre_verification_gas: userop.pre_verification_gas,
                     max_fee_per_gas: userop.max_fee_per_gas,
                     verification_gas_limit: userop.verification_gas_limit,
-                    sender: userop.sender.clone(),
+                    sender: userop.sender,
                     paymaster_and_data: userop.paymaster_and_data.clone(),
                     signature: userop.signature.clone(),
                     call_gas_limit: userop.call_gas_limit,
@@ -58,7 +58,7 @@ impl UserOpVersion {
                     pre_verification_gas: userop.pre_verification_gas,
                     max_fee_per_gas: userop.max_fee_per_gas,
                     verification_gas_limit: userop.verification_gas_limit,
-                    sender: userop.sender.clone(),
+                    sender: userop.sender,
                     paymaster_data: userop.paymaster_data.clone().unwrap_or_default(),
                     factory: userop.factory.unwrap_or_default(),
                     factory_data: userop.factory_data.clone().unwrap_or_default(),

server/src/http/routes/sign_typed_data.rs

@@ -270,9 +270,12 @@ async fn sign_single_typed_data(
     match result {
         Ok(signature) => {
             // Convert typed data to JSON string for signed_data field
-            let signed_data = serde_json::to_string(typed_data)
-                .unwrap_or_else(|_| "Failed to serialize typed data".to_string());
-            SignResultItem::success(signature, signed_data)
+            match serde_json::to_string(typed_data) {
+                Ok(signed_data) => SignResultItem::success(signature, signed_data),
+                Err(e) => SignResultItem::failure(EngineError::ValidationError {
+                    message: format!("Failed to serialize typed data: {}", e),
+                }),
+            }
         }
         Err(e) => SignResultItem::failure(e),
     }