Address review comments

Author: d4mr

sdk/src/services/BackendWalletService.ts

@@ -631,7 +631,7 @@ export class BackendWalletService {
 
     /**
      * Send a batch of raw transactions atomically
-     * Send a batch of raw transactions in a single UserOp. Can only be used with smart wallets.
+     * Send a batch of raw transactions in a single UserOp. Transactions will be sent in-order and atomically. Can only be used with smart wallets.
      * @param chain A chain ID ("137") or slug ("polygon-amoy-testnet"). Chain ID is preferred.
      * @param xBackendWalletAddress Backend wallet address
      * @param requestBody
@@ -643,7 +643,7 @@ export class BackendWalletService {
      * @returns any Default Response
      * @throws ApiError
      */
-    public sendTransactionsAtomic(
+    public sendTransactionBatchAtomic(
         chain: string,
         xBackendWalletAddress: string,
         requestBody: {
@@ -652,7 +652,13 @@ export class BackendWalletService {
                  * A contract or wallet address
                  */
                 toAddress?: string;
+                /**
+                 * A valid hex string
+                 */
                 data: string;
+                /**
+                 * An amount in wei (no decimals). Example: "50000000000"
+                 */
                 value: string;
             }>;
         },
@@ -671,7 +677,7 @@ export class BackendWalletService {
     }> {
         return this.httpRequest.request({
             method: 'POST',
-            url: '/backend-wallet/{chain}/send-transactions-atomic',
+            url: '/backend-wallet/{chain}/send-transaction-batch-atomic',
             path: {
                 'chain': chain,
             },

src/server/routes/backend-wallet/send-transactions-atomic.ts renamed to src/server/routes/backend-wallet/send-transaction-batch-atomic.ts

@@ -3,7 +3,6 @@ import type { FastifyInstance } from "fastify";
 import { StatusCodes } from "http-status-codes";
 import type { Address, Hex } from "thirdweb";
 import { insertTransaction } from "../../../shared/utils/transaction/insert-transaction";
-import { AddressSchema } from "../../schemas/address";
 import {
   requestQuerystringSchema,
   standardResponseSchema,
@@ -22,36 +21,29 @@ import {
   WalletDetailsError,
 } from "../../../shared/db/wallets/get-wallet-details";
 import { createCustomError } from "../../middleware/error";
+import { RawTransactionParamsSchema } from "../../schemas/transaction/raw-transaction-parms";
 
 const requestBodySchema = Type.Object({
-  transactions: Type.Array(
-    Type.Object({
-      toAddress: Type.Optional(AddressSchema),
-      data: Type.String({
-        examples: ["0x..."],
-      }),
-      value: Type.String({
-        examples: ["10000000"],
-      }),
-    }),
-  ),
+  transactions: Type.Array(RawTransactionParamsSchema, {
+    minItems: 1,
+  }),
 });
 
-export async function sendTransactionsAtomicRoute(fastify: FastifyInstance) {
+export async function sendTransactionBatchAtomicRoute(fastify: FastifyInstance) {
   fastify.route<{
     Params: Static<typeof walletChainParamSchema>;
     Body: Static<typeof requestBodySchema>;
     Reply: Static<typeof transactionWritesResponseSchema>;
     Querystring: Static<typeof requestQuerystringSchema>;
   }>({
     method: "POST",
-    url: "/backend-wallet/:chain/send-transactions-atomic",
+    url: "/backend-wallet/:chain/send-transaction-batch-atomic",
     schema: {
       summary: "Send a batch of raw transactions atomically",
       description:
-        "Send a batch of raw transactions in a single UserOp. Can only be used with smart wallets.",
+        "Send a batch of raw transactions in a single UserOp. Transactions will be sent in-order and atomically. Can only be used with smart wallets.",
       tags: ["Backend Wallet"],
-      operationId: "sendTransactionsAtomic",
+      operationId: "sendTransactionBatchAtomic",
       params: walletChainParamSchema,
       body: requestBodySchema,
       headers: Type.Omit(walletWithAAHeaderSchema, ["x-transaction-mode"]),

src/server/routes/contract/read/read-batch.ts

@@ -59,7 +59,7 @@ type RouteGeneric = {
   Reply: Static<typeof responseSchema>;
 };
 
-export async function readMulticallRoute(fastify: FastifyInstance) {
+export async function readBatchRoute(fastify: FastifyInstance) {
   fastify.route<RouteGeneric>({
     method: "POST",
     url: "/contract/:chain/read-batch",

src/server/routes/index.ts

@@ -111,8 +111,8 @@ import { getWebhooksEventTypes } from "./webhooks/events";
 import { getAllWebhooksData } from "./webhooks/get-all";
 import { revokeWebhook } from "./webhooks/revoke";
 import { testWebhookRoute } from "./webhooks/test";
-import { readMulticallRoute } from "./contract/read/read-batch";
-import { sendTransactionsAtomicRoute } from "./backend-wallet/send-transactions-atomic";
+import { readBatchRoute } from "./contract/read/read-batch";
+import { sendTransactionBatchAtomicRoute } from "./backend-wallet/send-transaction-batch-atomic";
 
 export async function withRoutes(fastify: FastifyInstance) {
   // Backend Wallets
@@ -126,7 +126,7 @@ export async function withRoutes(fastify: FastifyInstance) {
   await fastify.register(withdraw);
   await fastify.register(sendTransaction);
   await fastify.register(sendTransactionBatch);
-  await fastify.register(sendTransactionsAtomicRoute);
+  await fastify.register(sendTransactionBatchAtomicRoute);
   await fastify.register(signTransaction);
   await fastify.register(signMessageRoute);
   await fastify.register(signTypedData);
@@ -195,7 +195,7 @@ export async function withRoutes(fastify: FastifyInstance) {
 
   // Generic
   await fastify.register(readContract);
-  await fastify.register(readMulticallRoute);
+  await fastify.register(readBatchRoute);
   await fastify.register(writeToContract);
 
   // Contract Events

src/server/schemas/transaction/raw-transaction-parms.ts

@@ -0,0 +1,9 @@
+import { Type } from "@sinclair/typebox";
+import { AddressSchema, HexSchema } from "../address";
+import { WeiAmountStringSchema } from "../number";
+
+export const RawTransactionParamsSchema = Type.Object({
+  toAddress: Type.Optional(AddressSchema),
+  data: HexSchema,
+  value: WeiAmountStringSchema,
+});

src/shared/db/wallets/get-wallet-details.ts

@@ -1,4 +1,4 @@
-import LruMap from "mnemonist/lru-map";
+import LRUMap from "mnemonist/lru-map";
 import { getAddress } from "thirdweb";
 import { z } from "zod";
 import type { PrismaTransaction } from "../../schemas/prisma";
@@ -131,7 +131,7 @@ export type SmartBackendWalletType = (typeof SmartBackendWalletTypes)[number];
 export type BackendWalletType = (typeof BackendWalletTypes)[number];
 export type ParsedWalletDetails = z.infer<typeof walletDetailsSchema>;
 
-export const walletDetailsCache = new LruMap<string, ParsedWalletDetails>(2048);
+export const walletDetailsCache = new LRUMap<string, ParsedWalletDetails>(2048);
 /**
  * Return the wallet details for the given address.
  *