Add support for untyped contract args in /write

Author: joaquim-verges

src/server/routes/contract/write/write.ts

@@ -1,8 +1,8 @@
-import { Type, type Static } from "@sinclair/typebox";
+import { type Static, Type } from "@sinclair/typebox";
 import type { FastifyInstance } from "fastify";
 import { StatusCodes } from "http-status-codes";
 import { prepareContractCall, resolveMethod } from "thirdweb";
-import type { AbiFunction } from "thirdweb/utils";
+import { type AbiFunction, parseAbiParams } from "thirdweb/utils";
 import { getContractV5 } from "../../../../utils/cache/getContractv5";
 import { prettifyError } from "../../../../utils/error";
 import { queueTransaction } from "../../../../utils/transaction/queueTransation";
@@ -92,10 +92,14 @@ export async function writeToContract(fastify: FastifyInstance) {
           "BAD_REQUEST",
         );
       }
+      const params = parseAbiParams(
+        method.inputs.map((i) => i.type),
+        args,
+      );
       const transaction = prepareContractCall({
         contract,
         method,
-        params: args,
+        params,
         ...parseTransactionOverrides(txOverrides),
       });
 

test/e2e/tests/write.test.ts

@@ -69,6 +69,63 @@ describe("Write Tests", () => {
     expect(writeTransactionStatus.minedAt).toBeDefined();
   });
 
+  test.only("Write to a contract with untyped args", async () => {
+    const res = await engine.deploy.deployNftDrop(
+      CONFIG.CHAIN.id.toString(),
+      backendWallet,
+      {
+        contractMetadata: {
+          name: "test token",
+          platform_fee_basis_points: 0,
+          platform_fee_recipient: zeroAddress,
+          symbol: "TT",
+          trusted_forwarders: [],
+          seller_fee_basis_points: 0,
+          fee_recipient: zeroAddress,
+        },
+      },
+    );
+
+    expect(res.result.queueId).toBeDefined();
+    assert(res.result.queueId, "queueId must be defined");
+    expect(res.result.deployedAddress).toBeDefined();
+    const nftDropContractAddress = res.result.deployedAddress;
+
+    if (!nftDropContractAddress) {
+      throw new Error("nftDropContractAddress must be defined");
+    }
+
+    const transactionStatus = await pollTransactionStatus(
+      engine,
+      res.result.queueId,
+      true,
+    );
+
+    expect(transactionStatus.minedAt).toBeDefined();
+    const writeRes = await engine.contract.write(
+      CONFIG.CHAIN.id.toString(),
+      nftDropContractAddress,
+      backendWallet,
+      {
+        functionName: "setApprovalForAll",
+        args: [
+          "0x1234567890123456789012345678901234567890",
+          "true", // string instead of bool
+        ],
+      },
+    );
+
+    expect(writeRes.result.queueId).toBeDefined();
+
+    const writeTransactionStatus = await pollTransactionStatus(
+      engine,
+      writeRes.result.queueId,
+      true,
+    );
+
+    expect(writeTransactionStatus.minedAt).toBeDefined();
+  });
+
   test("Write to a contract with function signature", async () => {
     const writeRes = await engine.contract.write(
       CONFIG.CHAIN.id.toString(),