Remove bad tests

Author: jakeloo

internal/orchestrator/committer_test.go

@@ -407,145 +407,6 @@ func TestCleanupProcessedStagingBlocks(t *testing.T) {
 	mockStagingStorage.EXPECT().DeleteOlderThan(chainID, big.NewInt(90)).Return(nil)
 	committer.cleanupProcessedStagingBlocks()
 }
-
-func TestPublishParallelMode(t *testing.T) {
-	defer func() { config.Cfg = config.Config{} }()
-	config.Cfg.Publisher.Mode = "parallel"
-
-	mockRPC := mocks.NewMockIRPCClient(t)
-	mockMainStorage := mocks.NewMockIMainStorage(t)
-	mockStagingStorage := mocks.NewMockIStagingStorage(t)
-	mockOrchestratorStorage := mocks.NewMockIOrchestratorStorage(t)
-	mockStorage := storage.IStorage{
-		MainStorage:         mockMainStorage,
-		StagingStorage:      mockStagingStorage,
-		OrchestratorStorage: mockOrchestratorStorage,
-	}
-	committer := NewCommitter(mockRPC, mockStorage)
-	committer.workMode = WorkModeLive
-
-	chainID := big.NewInt(1)
-	blockData := []common.BlockData{
-		{Block: common.Block{ChainId: chainID, Number: big.NewInt(101)}},
-		{Block: common.Block{ChainId: chainID, Number: big.NewInt(102)}},
-	}
-
-	publishDone := make(chan struct{})
-
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-	mockStagingStorage.EXPECT().GetLastPublishedBlockNumber(chainID).Return(big.NewInt(100), nil)
-	mockStagingStorage.EXPECT().GetStagingData(mock.Anything).Return(blockData, nil)
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-	mockStagingStorage.EXPECT().SetLastPublishedBlockNumber(chainID, big.NewInt(102)).RunAndReturn(func(*big.Int, *big.Int) error {
-		close(publishDone)
-		return nil
-	})
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-
-	err := committer.publish(context.Background())
-	assert.NoError(t, err)
-
-	select {
-	case <-publishDone:
-	case <-time.After(2 * time.Second):
-		t.Fatal("SetLastPublishedBlockNumber was not called")
-	}
-
-	mockStagingStorage.AssertNotCalled(t, "DeleteOlderThan", mock.Anything, mock.Anything)
-}
-
-func TestRunPublishLoopPublishesWhenBehind(t *testing.T) {
-	defer func() { config.Cfg = config.Config{} }()
-	config.Cfg.Publisher.Mode = "parallel"
-	config.Cfg.Publisher.Enabled = false
-
-	mockRPC := mocks.NewMockIRPCClient(t)
-	mockMainStorage := mocks.NewMockIMainStorage(t)
-	mockStagingStorage := mocks.NewMockIStagingStorage(t)
-	mockOrchestratorStorage := mocks.NewMockIOrchestratorStorage(t)
-	mockStorage := storage.IStorage{
-		MainStorage:         mockMainStorage,
-		StagingStorage:      mockStagingStorage,
-		OrchestratorStorage: mockOrchestratorStorage,
-	}
-	committer := NewCommitter(mockRPC, mockStorage)
-	committer.workMode = WorkModeLive
-	committer.lastCommittedBlock.Store(102)
-
-	chainID := big.NewInt(1)
-	blockData := []common.BlockData{
-		{Block: common.Block{ChainId: chainID, Number: big.NewInt(101)}},
-		{Block: common.Block{ChainId: chainID, Number: big.NewInt(102)}},
-	}
-
-	publishDone := make(chan struct{})
-	deleteDone := make(chan struct{})
-
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-	mockStagingStorage.EXPECT().GetLastPublishedBlockNumber(chainID).Return(big.NewInt(100), nil)
-	mockStagingStorage.EXPECT().GetStagingData(mock.Anything).Return(blockData, nil)
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-
-	ctx, cancel := context.WithCancel(context.Background())
-	mockStagingStorage.EXPECT().SetLastPublishedBlockNumber(chainID, big.NewInt(102)).RunAndReturn(func(*big.Int, *big.Int) error {
-		close(publishDone)
-		cancel()
-		return nil
-	})
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-	mockStagingStorage.EXPECT().DeleteOlderThan(chainID, big.NewInt(102)).RunAndReturn(func(*big.Int, *big.Int) error {
-		close(deleteDone)
-		return nil
-	})
-
-	go committer.runPublishLoop(ctx, time.Millisecond)
-
-	select {
-	case <-publishDone:
-	case <-time.After(2 * time.Second):
-		t.Fatal("publish not triggered")
-	}
-	select {
-	case <-deleteDone:
-	case <-time.After(2 * time.Second):
-		t.Fatal("DeleteOlderThan not called")
-	}
-}
-
-func TestRunPublishLoopDoesNothingWhenNoNewBlocks(t *testing.T) {
-	defer func() { config.Cfg = config.Config{} }()
-	config.Cfg.Publisher.Mode = "parallel"
-	config.Cfg.Publisher.Enabled = false
-
-	mockRPC := mocks.NewMockIRPCClient(t)
-	mockMainStorage := mocks.NewMockIMainStorage(t)
-	mockStagingStorage := mocks.NewMockIStagingStorage(t)
-	mockOrchestratorStorage := mocks.NewMockIOrchestratorStorage(t)
-	mockStorage := storage.IStorage{
-		MainStorage:         mockMainStorage,
-		StagingStorage:      mockStagingStorage,
-		OrchestratorStorage: mockOrchestratorStorage,
-	}
-	committer := NewCommitter(mockRPC, mockStorage)
-	committer.workMode = WorkModeLive
-	committer.lastCommittedBlock.Store(102)
-
-	chainID := big.NewInt(1)
-
-	mockRPC.EXPECT().GetChainID().Return(chainID)
-	mockStagingStorage.EXPECT().GetLastPublishedBlockNumber(chainID).Return(big.NewInt(105), nil)
-	mockStagingStorage.EXPECT().GetStagingData(mock.Anything).Return([]common.BlockData{}, nil)
-
-	ctx, cancel := context.WithCancel(context.Background())
-	go committer.runPublishLoop(ctx, time.Millisecond)
-	time.Sleep(2 * time.Millisecond)
-	cancel()
-	time.Sleep(10 * time.Millisecond)
-
-	mockStagingStorage.AssertNotCalled(t, "SetLastPublishedBlockNumber", mock.Anything, mock.Anything)
-	mockStagingStorage.AssertNotCalled(t, "DeleteOlderThan", mock.Anything, mock.Anything)
-}
-
 func TestHandleGap(t *testing.T) {
 	mockRPC := mocks.NewMockIRPCClient(t)
 	mockMainStorage := mocks.NewMockIMainStorage(t)