Skip to content

Commit 4873720

Browse files
committed
Update s3 connector timeout
1 parent c4b86db commit 4873720

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

cmd/root.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,10 @@ func init() {
229229
rootCmd.PersistentFlags().String("migrator-destination-s3-secretAccessKey", "", "S3 secret access key for migrator destination")
230230
rootCmd.PersistentFlags().String("migrator-destination-s3-endpoint", "", "S3 endpoint URL for migrator destination")
231231
rootCmd.PersistentFlags().String("migrator-destination-s3-format", "parquet", "S3 storage format for migrator destination")
232-
rootCmd.PersistentFlags().Int64("migrator-destination-s3-bufferSizeMB", 512, "S3 buffer size in MB before flush for migrator destination")
233-
rootCmd.PersistentFlags().Int("migrator-destination-s3-bufferTimeoutSeconds", 300, "S3 buffer timeout in seconds before flush for migrator destination")
232+
rootCmd.PersistentFlags().Int64("migrator-destination-s3-bufferSizeMB", 0, "S3 buffer size in MB before flush for migrator destination")
233+
rootCmd.PersistentFlags().Int("migrator-destination-s3-bufferTimeoutSeconds", 0, "S3 buffer timeout in seconds before flush for migrator destination")
234234
rootCmd.PersistentFlags().Int("migrator-destination-s3-maxBlocksPerFile", 0, "S3 max blocks per file for migrator destination")
235-
rootCmd.PersistentFlags().Uint("migrator-batchSize", 2000, "Batch size for storage operations in migrator")
235+
rootCmd.PersistentFlags().Uint("migrator-batchSize", 0, "Batch size for storage operations in migrator")
236236
rootCmd.PersistentFlags().Uint("migrator-startBlock", 0, "Start block for migration")
237237
rootCmd.PersistentFlags().Uint("migrator-endBlock", 0, "End block for migration")
238238
rootCmd.PersistentFlags().Uint("migrator-workerCount", 0, "Worker count for migration")

internal/storage/s3.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,11 @@ func NewS3Connector(cfg *config.S3StorageConfig) (*S3Connector, error) {
9797
}
9898
}
9999

100-
// Set buffer defaults
101100
if cfg.BufferSize == 0 {
102-
cfg.BufferSize = 1024 // 1GB default
101+
cfg.BufferSize = 512 // 512MB default
103102
}
104103
if cfg.BufferTimeout == 0 {
105-
cfg.BufferTimeout = 300 // 5 minutes default
104+
cfg.BufferTimeout = 1 * 60 * 60 // 1 hour in seconds default
106105
}
107106

108107
// Create formatter based on format

0 commit comments

Comments
 (0)