changes from comments

Author: nischitpra

cmd/root.go

@@ -30,7 +30,7 @@ func Execute() {
 func init() {
 	cobra.OnInitialize(initConfig)
 
-	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is ./configs/config.yml)")
+	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "optional config file path (defaults to env-only when unset)")
 	rootCmd.AddCommand(committerCmd)
 	rootCmd.AddCommand(backfillCmd)
 }

internal/backfill/backfill.go

@@ -36,6 +36,7 @@ func RunBackfill() {
 	metrics.BackfillEndBlock.WithLabelValues(indexerName, chainIdStr).Set(float64(endBlockNumber))
 
 	wg := sync.WaitGroup{}
+	wg.Add(1)
 	go saveBlockDataToS3(&wg)
 	channelValidBlockData(startBlockNumber, endBlockNumber)
 	wg.Wait()
@@ -66,8 +67,6 @@ func saveBlockDataToS3(wg *sync.WaitGroup) {
 			panic(r)
 		}
 	}()
-
-	wg.Add(1)
 	defer wg.Done()
 
 	for blockdata := range blockdataChannel {

internal/committer/poollatest.go

@@ -20,15 +20,14 @@ func pollLatest() error {
 
 	for {
 		latestBlock, err := libs.RpcClient.GetLatestBlockNumber(context.Background())
-
-		// Update latest block number metric
-		metrics.CommitterLatestBlockNumber.WithLabelValues(indexerName, chainIdStr).Set(float64(latestBlock.Uint64()))
-
 		if err != nil {
 			log.Warn().Err(err).Msg("Failed to get latest block number, retrying...")
 			time.Sleep(250 * time.Millisecond)
 			continue
 		}
+		// Update latest block number metric
+		metrics.CommitterLatestBlockNumber.WithLabelValues(indexerName, chainIdStr).Set(float64(latestBlock.Uint64()))
+
 		if nextBlockNumber >= latestBlock.Uint64() {
 			time.Sleep(250 * time.Millisecond)
 			continue