Merge pull request #189 from thirdweb-dev/np/decode_fix

nischitpra · web-flow · commit 8262daff71f4 · 2025-04-09T19:02:30.000+08:00
check topic length before decode
diff --git a/internal/common/log.go b/internal/common/log.go
@@ -165,6 +165,9 @@ func (l *Log) Decode(eventABI *abi.Event) *DecodedLog {
 }
 
 func decodeIndexedArgument(argType abi.Type, topic string) (interface{}, error) {
+	if len(topic) < 3 {
+		return nil, fmt.Errorf("invalid topic %s", topic)
+	}
 	topicBytes := gethCommon.Hex2Bytes(topic[2:]) // Remove "0x" prefix
 	switch argType.T {
 	case abi.AddressTy:

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,9 @@ func (l Log) Decode(eventABI abi.Event) *DecodedLog {`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`func decodeIndexedArgument(argType abi.Type, topic string) (interface{}, error) {`
	`168`	`+ if len(topic) < 3 {`
	`169`	`+ return nil, fmt.Errorf("invalid topic %s", topic)`
	`170`	`+ }`
`168`	`171`	`topicBytes := gethCommon.Hex2Bytes(topic[2:]) // Remove "0x" prefix`
`169`	`172`	`switch argType.T {`
`170`	`173`	`case abi.AddressTy:`