feat: include token type to response #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalyst17
force-pushed
the
feat/add-token-type-to-holders-response
branch
from
ad1c9e4 to
7fa0d4c
Compare
vernonjohnson
approved these changes
Mar 12, 2025
Contributor
vernonjohnson
left a comment
vernonjohnson
left a comment
There was a problem hiding this comment.
lgtm. just double check the failing test
Contributor
Author
hm weird, not getting it locally |
catalyst17
force-pushed
the
feat/add-token-type-to-holders-response
branch
from
7fa0d4c to
a4c676b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
token_typefield to theHolderModelstruct and included it in the serialization function.We need it to properly detect token types for NFTs handlers, specifically for further metadata resolutions.
What changed?
TokenTypefield to theHolderModelstruct with JSON tagtoken_typeand ClickHouse tagtoken_typeserializeHolderfunction to populate the newTokenTypefield from theholder.TokenTypevalueHow to test?
token_typefield in the JSON outputWhy make this change?
This change enhances the token holder API response by including the token type information, which allows clients to distinguish between different token standards (e.g., ERC-20, ERC-721, ERC-1155) without having to make additional queries. This provides more complete information about tokens in a single response.